Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 4, 2025

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

@premun
Copy link
Member

premun commented Apr 4, 2025

@ViktorHofer I don't have write access here so cannot push but can you add this to NuGet.config?

<!-- Feeds for packages built in the VMR (newly Arcade and other) -->
<add key="dotnet10-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet10-transport/nuget/v3/index.json" />

@akoeplinger
Copy link
Member

actually I don't think we can merge this as it contains the System.CommandLine bump that is blocked: #1364

@premun
Copy link
Member

premun commented Apr 4, 2025

I excluded System.CommandLine from future flows. We can either close the PR and trigger the subscription again or we can revert the System.CommandLine bump.
Since we already have other changes in the PR, I'd do the latter?

@premun
Copy link
Member

premun commented Apr 4, 2025

Thanks for the revert.

How about the prebuilts? Is that expected?

@akoeplinger
Copy link
Member

@dotnet/source-build do we need to update prebuild detection to account for the new arcade VMR versions?

@MichaelSimons
Copy link
Member

@dotnet/source-build do we need to update prebuild detection to account for the new arcade VMR versions?

Once the VMR flow is enabled for a repo, IMO we should remove the repo level SB legs. The VMR doesn't produce the SB intermediates which the repo level SB legs depend on. This will likely have a cascading effect on other repo's which depend on sourcelink. This is a downside from trying to change sourcelink outside of "the great switch"

@akoeplinger
Copy link
Member

akoeplinger commented Apr 4, 2025

hmm okay. I guess we could also just add the arcade packages to the prebuilt baseline for now since they aren't real issues and keep the SB leg?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that file permissions change intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's executable in arcade.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the flat flow works better with eng/common as I saw it fixing permissions on the first backflow in other repos too

@dotnet-maestro dotnet-maestro bot merged commit d893ad5 into main Apr 6, 2025
14 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-edabffd4-0bb2-4d67-8919-714c58d0b057 branch April 6, 2025 08:43
@akoeplinger
Copy link
Member

ah, didn't realize this would auto-merge... Let me know if we should revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants