-
Notifications
You must be signed in to change notification settings - Fork 133
[main] Source code updates from dotnet/dotnet #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Source code updates from dotnet/dotnet #1401
Conversation
|
@ViktorHofer I don't have write access here so cannot push but can you add this to <!-- Feeds for packages built in the VMR (newly Arcade and other) -->
<add key="dotnet10-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet10-transport/nuget/v3/index.json" /> |
|
actually I don't think we can merge this as it contains the System.CommandLine bump that is blocked: #1364 |
|
I excluded |
|
Thanks for the revert. How about the prebuilts? Is that expected? |
|
@dotnet/source-build do we need to update prebuild detection to account for the new arcade VMR versions? |
Once the VMR flow is enabled for a repo, IMO we should remove the repo level SB legs. The VMR doesn't produce the SB intermediates which the repo level SB legs depend on. This will likely have a cascading effect on other repo's which depend on sourcelink. This is a downside from trying to change sourcelink outside of "the great switch" |
|
hmm okay. I guess we could also just add the arcade packages to the prebuilt baseline for now since they aren't real issues and keep the SB leg? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that file permissions change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's executable in arcade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the flat flow works better with eng/common as I saw it fixing permissions on the first backflow in other repos too
|
ah, didn't realize this would auto-merge... Let me know if we should revert |
Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies