Skip to content

Initial implementation of direct git repo data reading #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmat merged 16 commits into from
Jun 21, 2019
Merged

Initial implementation of direct git repo data reading #288

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ce4ee16
Managed implementation of git repo data reading
tmat Jun 10, 2019
1f66afc
Move git data reader to Tasks.Git
tmat Jun 19, 2019
799c244
Remove Operations
tmat Jun 19, 2019
ff0c01b
Use managed git data reader implementation
tmat Jun 20, 2019
95edaf1
Test operations
tmat Jun 20, 2019
7e57501
Update tests
tmat Jun 20, 2019
25bc041
Caching
tmat Jun 21, 2019
13a8c86
Rename
tmat Jun 21, 2019
1a02678
Update packaging
tmat Jun 21, 2019
38d9818
Move to Core 3.0
tmat Jun 21, 2019
95796b1
Refactoring
tmat Jun 21, 2019
c35dae2
Add multi-project integration test
tmat Jun 21, 2019
33a3a91
.NET Core fixes
tmat Jun 21, 2019
752258f
Linux fixes
tmat Jun 21, 2019
02104bc
Fix invalid path checks
tmat Jun 21, 2019
b1918a9
Fix ignore test
tmat Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix ignore test
  • Loading branch information
@tmat
tmat committed Jun 21, 2019
commit b1918a97779e6d09700a4485c12059e5707bf12a
17 changes: 11 additions & 6 deletions src/Microsoft.Build.Tasks.Git.UnitTests/GitIgnoreTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public void IsIgnored_CaseSensitive()
// does not match "/*.c"
Assert.False(matcher.IsPathIgnored(Path.Combine(workingDir.Path, "A", "B", "C", "D1", "x.c")));

AssertEx.Equal(new[]
AssertEx.SetEqual(new[]
{
"/Repo/.git: True",
"/Repo/A/B/C/D1/b: True",
Expand All @@ -153,7 +153,7 @@ public void IsIgnored_CaseSensitive()
"/Repo/A/B: False",
"/Repo/A: False",
"/Repo: False"
}, matcher.DirectoryIgnoreStateCache.Select(kvp => $"{kvp.Key.Substring(rootDir.Path.Length)}: {kvp.Value}").OrderBy(s => s, StringComparer.Ordinal));
}, matcher.DirectoryIgnoreStateCache.Select(kvp => $"{kvp.Key.Substring(rootDir.Path.Length)}: {kvp.Value}"));
}

[Fact]
Expand Down Expand Up @@ -197,15 +197,20 @@ public void IsIgnored_IgnoreCase()
// matches "dir/" (treated as a directory path)
Assert.True(matcher.IsPathIgnored(Path.Combine(workingDir.Path, "A", "DiR") + Path.DirectorySeparatorChar));

// matches "dir/" (existing directory path)
Assert.True(matcher.IsPathIgnored(Path.Combine(workingDir.Path, "A", "DIR")));
if (Path.DirectorySeparatorChar == '\\')
{
// matches "dir/" (existing directory path, the directory DIR only exists on case-insensitive FS)
Assert.True(matcher.IsPathIgnored(Path.Combine(workingDir.Path, "A", "DIR")));
}

Assert.True(matcher.IsPathIgnored(Path.Combine(workingDir.Path, "A", "diR")));

AssertEx.Equal(new[]
AssertEx.SetEqual(new[]
{
"/Repo/A/DIr: True",
"/Repo/A: False",
"/Repo: False",
}, matcher.DirectoryIgnoreStateCache.Select(kvp => $"{kvp.Key.Substring(rootDir.Path.Length)}: {kvp.Value}").OrderBy(s => s, StringComparer.Ordinal));
}, matcher.DirectoryIgnoreStateCache.Select(kvp => $"{kvp.Key.Substring(rootDir.Path.Length)}: {kvp.Value}"));
}
}
}