Skip to content

Use submodule.name.url to determine the URL of a submodule #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmat merged 5 commits into from
Mar 2, 2020
Merged

Use submodule.name.url to determine the URL of a submodule #587

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9630c10
Use submodule.name.url to determine the URL of a submodule
tmat Mar 1, 2020
37e14cb
Fix
tmat Mar 1, 2020
17f04fe
Update README.md
tmat Mar 1, 2020
b7b0c3d
Update README.md
tmat Mar 1, 2020
d67ad51
Fix
tmat Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix
  • Loading branch information
@tmat
tmat committed Mar 2, 2020
commit d67ad51d82a8072d4bdef1c5ed5753a36df2440c
5 changes: 3 additions & 2 deletions src/Microsoft.Build.Tasks.Git.UnitTests/GitRepositoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,7 @@ public void Submodules_Errors()
{
"S10: 'sub10' 'http://github.com'",
"S11: 'sub11' 'http://github.com'",
"S9: 'sub9' 'http://github.com'",
"S4: 'sub4' ' '"
"S9: 'sub9' 'http://github.com'"
}, submodules.Select(s => $"{s.Name}: '{s.WorkingDirectoryRelativePath}' '{s.Url}'"));

var diagnostics = repository.GetSubmoduleDiagnostics();
Expand All @@ -308,6 +307,8 @@ public void Submodules_Errors()
string.Format(Resources.InvalidSubmodulePath, "S2", ""),
// Could not find a part of the path 'sub3\.git'.
TestUtilities.GetExceptionMessage(() => File.ReadAllText(Path.Combine(workingDir.Path, "sub3", ".git"))),
// Could not find a part of the path 'sub4\.git'.
TestUtilities.GetExceptionMessage(() => File.ReadAllText(Path.Combine(workingDir.Path, "sub4", ".git"))),
// Could not find a part of the path 'sub5\.git'.
TestUtilities.GetExceptionMessage(() => File.ReadAllText(Path.Combine(workingDir.Path, "sub5", ".git"))),
// Access to the path 'sub6\.git' is denied
Expand Down