Skip to content

add source-build pre-built detection #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmat merged 11 commits into from
May 16, 2023
Merged

add source-build pre-built detection #933

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8ce220b
add pre-build detection
oleksandr-didyk Jan 2, 2023
bcc159d
downgrade MSBuild to 16.8
oleksandr-didyk Jan 3, 2023
583813e
add clarifying comments; move source-build RID prop in CI
oleksandr-didyk Jan 10, 2023
8218b06
fixup sbrp definition; fixup invalid msbuild version prop
oleksandr-didyk Jan 11, 2023
db472d5
update changes made
oleksandr-didyk Apr 11, 2023
05bc0df
remove redundant CI arg
oleksandr-didyk Apr 11, 2023
89694bc
add missing sb attribute; bump arcade dep versions
oleksandr-didyk Apr 13, 2023
b8fef1f
remove obsolete pre-built exclusions; fixup dep versions
oleksandr-didyk May 4, 2023
81716f5
remove obsolete nuget source; fixup sourcebuild metadata
oleksandr-didyk May 4, 2023
c6ba833
fixup duplicate dependency declaration
oleksandr-didyk May 15, 2023
0b09480
add explanation for dotnet-sourcelink exclusion
oleksandr-didyk May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update changes made
  • Loading branch information
@oleksandr-didyk
oleksandr-didyk committed May 15, 2023
commit db472d5fb6b279a28b03d859b5272836a002ad83
4 changes: 3 additions & 1 deletion NuGet.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@
<add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" />
<add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
<add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />
<add key="dotnet8-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8-transport/nuget/v3/index.json" />
<add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" />
<!-- Feeds for source-build intermediates -->
<add key="dotnet-libraries-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries-transport/nuget/v3/index.json" />
<add key="dotnet8-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8-transport/nuget/v3/index.json" />
</packageSources>
<disabledPackageSources>
<clear />
Expand Down
7 changes: 6 additions & 1 deletion eng/SourceBuildPrebuiltBaseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
<!-- Additional documentation on pre-built detection can be found at https://aka.ms/source-build/pre-built -->
<!-- See aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. -->
<UsageData>
<IgnorePatterns>
<UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*" />
</IgnorePatterns>
<Usages>
<!-- MSBuild versions starting from 16.10.0 do not target NET Core -->
<!-- and fail the non-source-build -->
<Usage Id="Microsoft.Build" Version="16.8.0" IsDirectDependency="true" />
</Usages>
</UsageData>
22 changes: 13 additions & 9 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,16 @@
<Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.22272.1">
<Uri>https://github.com/dotnet/command-line-api</Uri>
<Sha>209b724a3c843253d3071e8348c353b297b0b8b5</Sha>
<Dependency Name="System.Text.Json" Version="8.0.0-alpha.1.22631.1">
</Dependency>
<Dependency Name="Microsoft.SourceBuild.Intermediate.command-line-api" Version="0.1.327201">
<Uri>https://github.com/dotnet/command-line-api</Uri>
<Sha>209b724a3c843253d3071e8348c353b297b0b8b5</Sha>
</Dependency>
<Dependency Name="System.Text.Json" Version="8.0.0-preview.4.23210.22">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>a6f84d42529494b3539684ed993fa554281215b7</Sha>
<Sha>7ebb8886920be7ed2e5f1c8784e4cea516d118d7</Sha>
<SourceBuild RepoName="runtime" ManagedOnly="false" />
</Dependency>
<!-- MSBuild versions starting from 16.10.0 do not target NET Core -->
<Dependency Name="Microsoft.Build" Version="16.8.0">
<Uri>https://github.com/dotnet/msbuild</Uri>
<Sha>a6f6699d1f70bf79db82030938d2c5e52d1e4d2e</Sha>
Expand All @@ -26,9 +30,9 @@
<Uri>https://github.com/dotnet/msbuild</Uri>
<Sha>a6f6699d1f70bf79db82030938d2c5e52d1e4d2e</Sha>
</Dependency>
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="8.0.0-alpha.1.23055.1">
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="8.0.0-alpha.1.23211.2">
<Uri>https://github.com/dotnet/source-build-reference-packages</Uri>
<Sha>a7d9aec195d309a8d25022553a43561441a599a8</Sha>
<Sha>c053ca210364dfa4904006b811249f14743e853e</Sha>
<SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" />
</Dependency>
</ProductDependencies>
Expand All @@ -43,14 +47,14 @@
<Sha>d76c30028584fb1d02d9b27dc48e65ad87f4ecfe</Sha>
<SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.SourceLink.GitHub" Version="1.2.0-beta-22518-02" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk">
<Dependency Name="Microsoft.SourceLink.GitHub" Version="1.2.0-beta-23117-02" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk">
<Uri>https://github.com/dotnet/sourcelink</Uri>
<Sha>d047202874ad79d72c75b6354c0f8a9a12d1b054</Sha>
<Sha>955e79b0b955a9f57078b2399a782fcde44a9261</Sha>
<SourceBuild RepoName="sourcelink" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="1.0.0-beta.22627.1" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk">
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="1.0.0-beta.23116.1" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk">
<Uri>https://github.com/dotnet/xliff-tasks</Uri>
<Sha>c9b8a539c59158e189e4a6b9ebcf29b748dcb843</Sha>
<Sha>69157952aba0f08738249af4454b045b553614c4</Sha>
<SourceBuild RepoName="xliff-tasks" ManagedOnly="true" />
</Dependency>
</ToolsetDependencies>
Expand Down
2 changes: 0 additions & 2 deletions src/SourceLink.Tools/Microsoft.SourceLink.Tools.Package.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
<GenerateDocumentationFile>false</GenerateDocumentationFile>
<DebugType>none</DebugType>
<GenerateDependencyFile>false</GenerateDependencyFile>
<!-- For System.Text.Json 8.x.y reference. Caused and should be removed by https://github.com/dotnet/sourcelink/issues/938-->
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>

<!-- NuGet -->
<IsPackable>true</IsPackable>
Expand Down