Skip to content

Do not report warnings when SourceLink packages are not referenced ex… #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmat merged 5 commits into from
Apr 7, 2023
Merged

Do not report warnings when SourceLink packages are not referenced ex… #991

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b91f1b
Do not report warnings when SourceLink packages are not referenced ex…
tmat Apr 7, 2023
f1f7383
Update tests
tmat Apr 7, 2023
cae322e
Fix
tmat Apr 7, 2023
6f9e7f7
Ignore .vscode
tmat Apr 7, 2023
2544d80
Fix
tmat Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests
  • Loading branch information
@tmat
tmat committed Apr 7, 2023
commit f1f7383705075d006196185836c9d3e86b4f596f
19 changes: 12 additions & 7 deletions src/SourceLink.Common.UnitTests/GenerateSourceLinkFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ public void Empty(bool noWarning)

Assert.True(task.Execute());

AssertEx.AssertEqualToleratingWhitespaceDifferences(
noWarning ? "" : "WARNING : " + string.Format(Resources.SourceControlInformationIsNotAvailableGeneratedSourceLinkEmpty),
engine.Log);
var expectedOutput =
(noWarning ? "" : "WARNING : " + string.Format(Resources.SourceControlInformationIsNotAvailableGeneratedSourceLinkEmpty) + Environment.NewLine) +
string.Format(Resources.SourceLinkEmptyNoExistingFile, sourceLinkFilePath);

AssertEx.AssertEqualToleratingWhitespaceDifferences(expectedOutput, engine.Log);

Assert.Null(task.SourceLink);
Assert.Null(task.FileWrite);
Expand Down Expand Up @@ -64,9 +66,11 @@ public void NoRepositoryUrl(bool noWarning)

Assert.True(task.Execute());

AssertEx.AssertEqualToleratingWhitespaceDifferences(
noWarning ? "" : "WARNING : " + string.Format(Resources.SourceControlInformationIsNotAvailableGeneratedSourceLinkEmpty),
engine.Log);
var expectedOutput =
(noWarning ? "" : "WARNING : " + string.Format(Resources.SourceControlInformationIsNotAvailableGeneratedSourceLinkEmpty) + Environment.NewLine) +
string.Format(Resources.SourceLinkEmptyNoExistingFile, sourceLinkFilePath);

AssertEx.AssertEqualToleratingWhitespaceDifferences(expectedOutput, engine.Log);

Assert.Null(task.SourceLink);
Assert.Null(task.FileWrite);
Expand All @@ -92,7 +96,8 @@ public void Empty_DeleteExistingFile()

Assert.True(task.Execute());

AssertEx.AssertEqualToleratingWhitespaceDifferences("", engine.Log);
AssertEx.AssertEqualToleratingWhitespaceDifferences(
string.Format(Resources.SourceLinkEmptyDeletingExistingFile, sourceLinkFile.Path), engine.Log);

Assert.Null(task.SourceLink);
Assert.Equal(sourceLinkFile.Path, task.FileWrite);
Expand Down