Skip to content

Conversation

@YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Jan 17, 2023

Problem

Sometimes the tests fail because the template samples package was installed but then later when instantiating the templates, the update checks detected a newer templates sample package being available in the feeds:
dotnet/sdk#29966

 The template "Contoso Sample 06" was created successfully.
      + 
      + An update for template package 'Microsoft.TemplateEngine.Samples::8.0.100-alpha.1.23066.9' is available.
      + To update the package use:
      +    dotnet new install Microsoft.TemplateEngine.Samples::8.0.100-alpha.1.23067.1

Solution

Use option --no-update-check

Checks:

  • [ N/A ] Added unit tests
  • [ N/A ] Added #nullable enable to all the modified files ?

@YuliiaKovalova YuliiaKovalova marked this pull request as ready for review January 17, 2023 14:24
@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner January 17, 2023 14:24
@ViktorHofer
Copy link
Member

Thanks for the quick fix

@ViktorHofer ViktorHofer enabled auto-merge (squash) January 17, 2023 14:29
@ViktorHofer ViktorHofer disabled auto-merge January 17, 2023 14:46
@ViktorHofer ViktorHofer enabled auto-merge (squash) January 17, 2023 14:47
@ViktorHofer
Copy link
Member

I think that one of the code owners need to approve first

@ViktorHofer ViktorHofer merged commit 3dcef8e into dotnet:main Jan 17, 2023
@YuliiaKovalova
Copy link
Member Author

/backport to release/7.0.2xx

@github-actions
Copy link
Contributor

Started backporting to release/7.0.2xx: https://github.com/dotnet/templating/actions/runs/3949600009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants