Skip to content

Remove the affected vscode package#2730

Merged
akshita31 merged 3 commits into
masterfrom
akshita31-patch-3
Dec 5, 2018
Merged

Remove the affected vscode package#2730
akshita31 merged 3 commits into
masterfrom
akshita31-patch-3

Conversation

@akshita31

Copy link
Copy Markdown
Contributor

As per : https://code.visualstudio.com/blogs/2018/11/26/event-stream, we need to update the vscode package

@akshita31 akshita31 requested a review from rchande December 5, 2018 19:41
@akshita31

Copy link
Copy Markdown
Contributor Author

cc @NTaylorMullen

@rchande

rchande commented Dec 5, 2018

Copy link
Copy Markdown

@akshita31 I think you need to update package.lock.json? Your build has this error:

npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.

@codecov

codecov Bot commented Dec 5, 2018

Copy link
Copy Markdown

Codecov Report

Merging #2730 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
+ Coverage    65.3%   65.46%   +0.16%     
==========================================
  Files         101      101              
  Lines        4355     4355              
  Branches      635      635              
==========================================
+ Hits         2844     2851       +7     
+ Misses       1326     1321       -5     
+ Partials      185      183       -2
Flag Coverage Δ
#integration 53.54% <ø> (+0.53%) ⬆️
#unit 85.1% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/omnisharp/server.ts 70.4% <0%> (+0.34%) ⬆️
src/features/diagnosticsProvider.ts 81.33% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad3500...742d109. Read the comment docs.

@codecov

codecov Bot commented Dec 5, 2018

Copy link
Copy Markdown

Codecov Report

Merging #2730 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
+ Coverage   64.94%   65.28%   +0.34%     
==========================================
  Files         101      101              
  Lines        4396     4396              
  Branches      633      635       +2     
==========================================
+ Hits         2855     2870      +15     
+ Misses       1355     1344      -11     
+ Partials      186      182       -4
Flag Coverage Δ
#integration 53.4% <ø> (+0.34%) ⬆️
#unit 85.11% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/omnisharp/server.ts 69.96% <0%> (-0.35%) ⬇️
src/features/diagnosticsProvider.ts 79.22% <0%> (+2.59%) ⬆️
src/omnisharp/delayTracker.ts 73.68% <0%> (+5.26%) ⬆️
src/features/completionItemProvider.ts 86.76% <0%> (+8.82%) ⬆️
src/features/documentation.ts 47.61% <0%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64866d...89f07ba. Read the comment docs.

@akshita31 akshita31 merged commit 80bf9ae into master Dec 5, 2018
@akshita31 akshita31 deleted the akshita31-patch-3 branch December 5, 2018 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants