Skip to content

[release/8.0] Set metadata for .NET release shipping assets in manifest #4183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lonitra merged 1 commit into from
Feb 28, 2024
Merged

[release/8.0] Set metadata for .NET release shipping assets in manifest #4183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Set metadata for .NET release shipping assets in manifest (#4173) 
* add publishing props file

* set metadata for assets
  • Loading branch information
@MilenaHristova
MilenaHristova committed Feb 27, 2024
commit cdc577dc485c14178c640d9ff2d171136f6ebeb5
5 changes: 5 additions & 0 deletions eng/Publishing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<Project>
<PropertyGroup>
<ProducesDotNetReleaseShippingAssets>true</ProducesDotNetReleaseShippingAssets>
</PropertyGroup>
</Project>
13 changes: 13 additions & 0 deletions src/publish/prepare-artifacts.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,11 @@
<PropertyGroup>
<PrepareArtifacts>true</PrepareArtifacts>
</PropertyGroup>

<Import Project="../tools/Sign.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />

<Import Project="$(RepositoryEngineeringDir)Publishing.props" Condition="Exists('$(RepositoryEngineeringDir)Publishing.props')" />

<!-- Since this repo doesn't use publish.proj, update the incoming arcade defaults to use MicrosoftDotNet500 -->
<ItemGroup>
<FileExtensionSignInfo Update="@(FileExtensionSignInfo->WithMetadataValue('CertificateName','Microsoft400'))" CertificateName="$(DotNetCertificateName)" />
Expand All @@ -49,6 +52,16 @@
PrepareArtifacts=$(PrepareArtifacts)" />
</Target>

<!--
Set metadata for assets that are not marked as NonShipping.
This is used to determine if the asset should be shipped as part of .NET release.
-->
<ItemDefinitionGroup>
<ItemsToPush>
<ManifestArtifactData Condition="'$(ProducesDotNetReleaseShippingAssets)' == 'true'">DotNetReleaseShipping=true</ManifestArtifactData>
</ItemsToPush>
</ItemDefinitionGroup>

<Target Name="PreparePublishToAzureBlobFeed"
AfterTargets="Build"
DependsOnTargets="FindDownloadedArtifacts;SignArtifacts;GenerateChecksums">
Expand Down