Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 17, 2024

Backport of #12156 to release/9.0-rc2

/cc @lonitra @jeffhandley

Customer Impact

We are marking the System.Formats.Nrbf APIs as [Experimental] in .NET 9 to leave the door open for making API changes in the next release. Since WinForms consumes these APIs, we need to suppress the diagnostic that will occur.

Testing

Created a local build of System.Formats.Nrbf with the assembly marked as [Experimental], consumed that build into the WinForms solution for all references, and found the projects that need to have the suppression in place.

Risk

Low. Suppressing a diagnostic that will be introduced in RC2.

Microsoft Reviewers: Open in CodeFlow

@github-actions github-actions bot requested a review from a team as a code owner September 17, 2024 17:35
@lonitra lonitra added servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria and removed servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels Sep 17, 2024
@jeffhandley
Copy link
Member

@lonitra I don't have permission to edit the issue description, but here's the template. It was already discussed and approved in Tactics.

Customer Impact

We are marking the System.Formats.Nrbf APIs as [Experimental] in .NET 9 to leave the door open for making API changes in the next release. Since WinForms consumes these APIs, we need to suppress the diagnostic that will occur.

Testing

Created a local build of System.Formats.Nrbf with the assembly marked as [Experimental], consumed that build into the WinForms solution for all references, and found the projects that need to have the suppression in place.

Risk

Low. Suppressing a diagnostic that will be introduced in RC2.

@codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.81742%. Comparing base (f1676f5) to head (83c1f9e).
Report is 2 commits behind head on release/9.0-rc2.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           release/9.0-rc2      #12162         +/-   ##
=========================================================
+ Coverage         74.81314%   74.81742%   +0.00427%     
=========================================================
  Files                 3022        3022                 
  Lines               630138      630138                 
  Branches             46785       46785                 
=========================================================
+ Hits                471426      471453         +27     
+ Misses              155322      155308         -14     
+ Partials              3390        3377         -13     
Flag Coverage Δ
Debug 74.81742% <ø> (+0.00427%) ⬆️
integration 18.03116% <ø> (+0.01445%) ⬆️
production 47.83499% <ø> (+0.00949%) ⬆️
test 97.00759% <ø> (ø)
unit 44.83952% <ø> (-0.01793%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra added the servicing-approved .NET Shiproom approved the PR for merge label Sep 17, 2024
@lonitra lonitra merged commit 3a62197 into release/9.0-rc2 Sep 17, 2024
@lonitra lonitra deleted the backport/pr-12156-to-release/9.0-rc2 branch September 17, 2024 18:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

servicing-approved .NET Shiproom approved the PR for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants