Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 11, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20220212.5
  • Date Produced: February 13, 2022 2:40:20 AM UTC
  • Commit: 78c6505cffe2558b036fbe44cd27038affbb6cce
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow

…0211.1

Microsoft.Windows.Compatibility , Microsoft.Win32.SystemEvents , Microsoft.Win32.Registry.AccessControl , Microsoft.NETCore.Platforms , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.ILAsm , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.PerformanceCounter , System.Diagnostics.EventLog , System.Configuration.ConfigurationManager , System.CodeDom , runtime.win-x86.Microsoft.NETCore.ILAsm , System.DirectoryServices , System.Drawing.Common , System.Security.Cryptography.Pkcs , System.Resources.Extensions , System.Reflection.MetadataLoadContext , System.IO.Packaging , runtime.win-x64.Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NETCore.App.Ref , System.Security.Cryptography.Xml , System.Security.Cryptography.ProtectedData , System.Security.Permissions , System.Windows.Extensions , System.Threading.AccessControl , System.Text.Json , System.Text.Encodings.Web , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
 From Version 7.0.0-preview.2.22109.10 -> To Version 7.0.0-preview.2.22111.1
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner February 11, 2022 13:09
ghost
ghost previously approved these changes Feb 11, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@dreddy-work
Copy link
Member

@JeremyKuhne , seems like there is an extra enforcement in marshaling directives use in latest runtime. Can you help check these failures with possible fix? Fix can be pushed to the same PR.

image

@JeremyKuhne
Copy link
Member

@AaronRobinsonMSFT, @jkoritzinsky any idea on why this would throw now? We generate this definition from tlbimp:

https://github.com/dotnet/winforms/blob/main/src/Accessibility/src/Accessibility.il#L505-L512

Here is the disassembled view of it:

    [ComImport]
    [TypeLibType(TypeLibTypeFlags.FHidden | TypeLibTypeFlags.FDual | TypeLibTypeFlags.FDispatchable)]
    [Guid("618736E0-3C3D-11CF-810C-00AA00389B71")]
    public interface IAccessible
    {
        //
        // Summary:
        //     The Accessibility.IAccessible interface and all of its exposed members are part
        //     of a managed wrapper for the Component Object Model (COM) IAccessible interface.
        //
        // Returns:
        //     An object.
        [DispId(-5000)]
        object accParent
        {
            [MethodImpl(MethodImplOptions.InternalCall)]
            [DispId(-5000)]
            [TypeLibFunc(TypeLibFuncFlags.FHidden)]
            [return: MarshalAs(UnmanagedType.IDispatch)]
            get;
        }

@jkoritzinsky
Copy link
Member

I've repro'd the issue locally. This is fallout from dotnet/runtime#64279. I'm working on a fix now.

…0211.16

Microsoft.Windows.Compatibility , Microsoft.Win32.SystemEvents , Microsoft.Win32.Registry.AccessControl , Microsoft.NETCore.Platforms , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.ILAsm , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.PerformanceCounter , System.Diagnostics.EventLog , System.Configuration.ConfigurationManager , System.CodeDom , runtime.win-x86.Microsoft.NETCore.ILAsm , System.DirectoryServices , System.Drawing.Common , System.Security.Cryptography.Pkcs , System.Resources.Extensions , System.Reflection.MetadataLoadContext , System.IO.Packaging , runtime.win-x64.Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NETCore.App.Ref , System.Security.Cryptography.Xml , System.Security.Cryptography.ProtectedData , System.Security.Permissions , System.Windows.Extensions , System.Threading.AccessControl , System.Text.Json , System.Text.Encodings.Web , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
 From Version 7.0.0-preview.2.22109.10 -> To Version 7.0.0-preview.2.22111.16
…0212.5

Microsoft.Windows.Compatibility , Microsoft.Win32.SystemEvents , Microsoft.Win32.Registry.AccessControl , Microsoft.NETCore.Platforms , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.ILAsm , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.PerformanceCounter , System.Diagnostics.EventLog , System.Configuration.ConfigurationManager , System.CodeDom , runtime.win-x86.Microsoft.NETCore.ILAsm , System.DirectoryServices , System.Drawing.Common , System.Security.Cryptography.Pkcs , System.Resources.Extensions , System.Reflection.MetadataLoadContext , System.IO.Packaging , runtime.win-x64.Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NETCore.App.Ref , System.Security.Cryptography.Xml , System.Security.Cryptography.ProtectedData , System.Security.Permissions , System.Windows.Extensions , System.Threading.AccessControl , System.Text.Json , System.Text.Encodings.Web , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
 From Version 7.0.0-preview.2.22109.10 -> To Version 7.0.0-preview.2.22112.5
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix has been consumed and this PR is green.

@dotnet-maestro dotnet-maestro bot merged commit 284780b into main Feb 13, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-8f7ed743-afca-4603-b8c8-cd218976c968 branch February 13, 2022 16:42
@ghost ghost locked as resolved and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants