Skip to content

Conversation

@dreddy-work
Copy link
Member

@dreddy-work dreddy-work commented Oct 21, 2022

Related to #7956.

Documenting the updated Anchor calculations in .NET 8.0 for future reference.

Microsoft Reviewers: Open in CodeFlow

@dreddy-work dreddy-work requested a review from a team as a code owner October 21, 2022 17:49
@ghost ghost assigned dreddy-work Oct 21, 2022
@dreddy-work dreddy-work changed the title Document updated AnchorCalculation in .NET 8.0 Document updated anchor calculation in .NET 8.0 Oct 21, 2022
@dreddy-work dreddy-work changed the title Document updated anchor calculation in .NET 8.0 Document updated anchor calculations in .NET 8.0 Oct 21, 2022
@ghost ghost added waiting-author-feedback The team requires more information from the author and removed waiting-author-feedback The team requires more information from the author labels Oct 24, 2022
@dreddy-work dreddy-work requested a review from RussKie October 24, 2022 02:50
Copy link
Member

@merriemcgaw merriemcgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly grammatical suggestions.

@ghost ghost added waiting-author-feedback The team requires more information from the author and removed waiting-author-feedback The team requires more information from the author labels Oct 24, 2022
RussKie
RussKie previously approved these changes Oct 25, 2022
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 🚀

@RussKie RussKie added the waiting-author-feedback The team requires more information from the author label Oct 27, 2022
@RussKie RussKie added the waiting-author-feedback The team requires more information from the author label Nov 2, 2022
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Nov 2, 2022
@dreddy-work dreddy-work requested a review from RussKie November 2, 2022 03:38
@dreddy-work dreddy-work dismissed merriemcgaw’s stale review November 2, 2022 04:20

addressed feedback

@RussKie RussKie disabled auto-merge November 2, 2022 05:04
@dreddy-work dreddy-work merged commit 0db7e32 into main Nov 2, 2022
@dreddy-work dreddy-work deleted the dev/dreddy/UpdateDocAnchorLayout branch November 2, 2022 15:45
@ghost ghost added this to the 8.0 Preview1 milestone Nov 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

design-discussion Ongoing discussion about design without consensus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants