Skip to content

Fix scaling in SplitContainer controls for high DPI machines #7990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dreddy-work merged 4 commits into from
Oct 23, 2022
Merged

Fix scaling in SplitContainer controls for high DPI machines #7990

dreddy-work merged 4 commits into from
Oct 23, 2022

Conversation

@dreddy-work
Copy link
Member

@dreddy-work dreddy-work commented Oct 21, 2022 •
edited by ghost
Loading

Fixes #3168 in combination with #7956

Proposed changes

  • Scaling SplitterDistance property when DPI changed event occurs.
  • Updating Panel sizes when FixedPanel property is set and DPI changed event occurs.
  • Add unit test for future reference.
Microsoft Reviewers: Open in CodeFlow

@dreddy-work dreddy-work requested a review from a team as a code owner October 21, 2022 21:30
@ghost ghost assigned dreddy-work Oct 21, 2022
RussKie
RussKie suggested changes Oct 23, 2022
View reviewed changes
@ghost ghost added waiting-author-feedback The team requires more information from the author and removed waiting-author-feedback The team requires more information from the author labels Oct 23, 2022
@dreddy-work dreddy-work requested a review from RussKie October 23, 2022 23:10
RussKie
RussKie previously approved these changes Oct 23, 2022
View reviewed changes
@dreddy-work dreddy-work enabled auto-merge October 23, 2022 23:12
@dreddy-work dreddy-work merged commit d9f3ad9 into main Oct 23, 2022
@dreddy-work dreddy-work deleted the dev/dreddy/SplitContainerfix branch October 23, 2022 23:57
@ghost ghost added this to the 8.0 Preview1 milestone Oct 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Tanya-Solyanik Tanya-Solyanik Awaiting requested review from Tanya-Solyanik

1 more reviewer

@RussKie RussKie RussKie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dreddy-work dreddy-work

Labels

None yet

Projects

None yet

Milestone

8.0 Preview1

Development

Successfully merging this pull request may close these issues.

Controls (with Anchor Right) scaling bugs inside splitContainer

3 participants

@dreddy-work @RussKie