Fix Anchors in PermonitorV2 mode applications. #8086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PermonitorV2 mode applications, when moving the Form from one monitor to the other, Form gets an invalid display rectangle for a brief period during the scaling of its child controls. Updating anchors, because of layout, during this period would end up invalid anchor calculations. For all scaling scenarios due to DPI changed event, we will be scaling anchors and avoid/skip recalculation of anchors and prevent using this invalid display rect. Following is the snippet where we see invalid DisplayRect of the Form for a brief period while moving from one monitor to the other.
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good.
How does this change affect your perf results?
Had you tested this change in apps where the anchored control is a container itself?
src/System.Windows.Forms/src/System/Windows/Forms/ContainerControl.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ContainerControl.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Layout/DefaultLayout.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Layout/DefaultLayout.cs
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Layout/DefaultLayout.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Nov 1, 2022
src/System.Windows.Forms/src/System/Windows/Forms/Layout/DefaultLayout.cs
Outdated
Show resolved
Hide resolved
RussKie
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
Member
Author
Yes. Form with Panel with anchored controls. And panel is anchored to Form. Works as expected. |
Tanya-Solyanik
approved these changes
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #8087
In PermonitorV2 mode applications, when moving the Form from one monitor to the other, Form gets an invalid display rectangle for a brief period during the scaling of its child controls. Updating anchors, because of layout, during this period would end up invalid anchor calculations. For all scaling scenarios due to DPI changed event, we will be scaling anchors and avoid/skip recalculation of anchors to prevent using this invalid display rect.
Following is the snippet where we see invalid DisplayRect of the Form for a brief period while moving from one monitor to the other.
Invalid state:
Final state:
Amending #7956
Microsoft Reviewers: Open in CodeFlow