Establish Code Coverage for wpf #10514
Conversation
There was a problem hiding this comment.
PR Overview
This PR establishes code coverage reporting for WPF by introducing a new codecov configuration and integrating coverage reporting into the CI pipeline.
- Added a codecov.yml configuration file with detailed coverage thresholds and flag definitions.
- Updated README.md to include a codecov badge for production coverage.
- Modified eng/pipeline-pr.yml to pass coverage parameters through build and test steps and to upload coverage data.
Reviewed Changes
| File | Description |
|---|---|
| codecov.yml | New configuration for code coverage thresholds and flags. |
| README.md | Added a codecov badge linking to coverage reports. |
| eng/pipeline-pr.yml | Updated pipeline tasks to include coverage parameters and upload. |
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
codecov.yml:14
- Verify that the pattern 'eng/::/' is correctly formatted for its intended purpose, as it may not match the desired paths.
- "eng/::/"
dotnet-policy-service
bot
added
the
PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10514 +/- ##
==========================================
Coverage ? 10.99998%
==========================================
Files ? 3215
Lines ? 648474
Branches ? 71534
==========================================
Hits ? 71332
Misses ? 576143
Partials ? 999
Flags with carried forward coverage won't be shown. Click here to find out more. |
| '`' /*96*/, '|' /*124*/, '~' /*126*/, | ||
| ]; | ||
|
|
||
| private static ReadOnlySpan<char> AllowedCharacters => s_allowedCharacters; |
There was a problem hiding this comment.
Why was this changed? Makes no sense?
There was a problem hiding this comment.
Yep, just the same thing. This was done just to fix some test errors on CI:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=964386&view=ms.vss-test-web.build-test-results-tab&runId=25692748&resultId=100633&paneView=debug
at System.Runtime.CompilerServices.RuntimeHelpers.GetSpanDataFrom(RuntimeFieldHandle fldHandle, RuntimeTypeHandle targetTypeHandle, Int32& count)
at System.Runtime.CompilerServices.RuntimeHelpers.CreateSpan[T](RuntimeFieldHandle fldHandle)
at MS.Internal.ContentType.get_AllowedCharacters() in D:\a\_work\1\s\src\Microsoft.DotNet.Wpf\src\WindowsBase\MS\Internal\ContentType.cs:line 657
at MS.Internal.ContentType.IsAllowedCharacter(Char character) in D:\a\_work\1\s\src\Microsoft.DotNet.Wpf\src\WindowsBase\MS\Internal\ContentType.cs:line 604
There was a problem hiding this comment.
@singhashish-wpf Yeah but that should never fail, it makes no sense why it should throw Argument_BadFieldForInitializeArray from GetSpanDataFrom.
Microsoft Reviewers: Open in CodeFlow