Skip to content

Make use of NonValidated headers #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MihaZupan merged 1 commit into from
Jan 11, 2022
Merged

Make use of NonValidated headers #1507

MihaZupan merged 1 commit into from
Jan 11, 2022

Conversation

@MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Jan 10, 2022

Closes #1347
Memory-wise, we go from 64 objects to 38 (-41%), or 4366 B to 3180 (-27%) per request.

RPS-wise, this change is a win of ~5-6% on citrine and ~7% on perf machines. Closes #1083

Before:
image

After:
image

We save 26 objects:

  • 8x string
  • 5x string[]
  • 4x HeaderStoreItemInfo
  • 4x (MediaType/NameValue/Product/ProductInfo)HeaderValue
  • 2x HttpHeadersEnumerator
  • 1x ObjectCollection
  • 1x Uri
  • 1x DateTimeOffset (box)

@MihaZupan MihaZupan added this to the YARP 1.1.0 milestone Jan 10, 2022
@MihaZupan MihaZupan requested a review from Tratcher as a code owner January 10, 2022 19:29
@MihaZupan MihaZupan merged commit e8c731e into dotnet:main Jan 11, 2022
@MihaZupan MihaZupan mentioned this pull request Feb 3, 2022
Merged
@MihaZupan MihaZupan modified the milestones: YARP 1.1.0, YARP 1.1.0-RC1 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

YARP 1.1.0-RC1

Development

Successfully merging this pull request may close these issues.

Use non-validated HttpClient headers Investigate too low perf gain from NonValidated headers API

2 participants

@MihaZupan @Tratcher