Convert encoding of strings before running through iconv()
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring up to date with upstream
We were receiving a lot of errors with mandarin strings, This fix will change unknown characters to `?` and prevent `iconv()` throwing an error Signed-off-by: Marnu Lombard <[email protected]>
Instead of using the passed in encoding which could contain `//TRANSLIT` or `//IGNORE`, Use the detected encoding of the string that `imap_mime_header_decode()` supplies us. Signed-off-by: Marnu Lombard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were receiving a lot of errors with mandarin strings,
This fix will change unknown characters to
?and preventiconv()throwing an error