Skip to content

Adding TDS (aka Microsoft SQL) to dialects. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adding TDS (aka Microsoft SQL) to dialects. #18

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffb8b5e
Adding TDS (aka Microsoft SQL) to dialects.
rdhammond Aug 9, 2013
a00799f
Adjusted escaping to deal with MSSQL's insano dialect for nested brac…
rdhammond Aug 9, 2013
19b86bd
Added alternate query handler hooks for TDS---mostly pertaining to LI…
rdhammond Aug 9, 2013
eeebd79
Added a unit test to make sure LIMIT and OFFSET are playing together …
rdhammond Aug 9, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjusted escaping to deal with MSSQL's insano dialect for nested brac… 
…kets. :P
  • Loading branch information
@rdhammond
rdhammond committed Aug 9, 2013
commit a00799fb666a880f2ac4285beb39e74f6c97547e
2 changes: 1 addition & 1 deletion lib/Dialects/tds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports.escapeId = function () {
return exports.escapeVal(el.escapes.shift());
});
}
return "[" + el.replace(/\[/g, '[[').replace(/\]/g, ']]') + "]";
return "[" + el.replace(/\[/g, '[[]').replace(/(^|[^\[])\]/g, '[]]') + "]";
}).join(".");
};

Expand Down
2 changes: 1 addition & 1 deletion test/integration/test-dialect-tds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ assert.equal(

assert.equal(
dialect.escapeId('table', 'co[l'),
"[table].[co[[l]"
"[table].[co[[]l]"
);

assert.equal(
Expand Down