Skip to content

Received params #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DawidKopec94 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Received params #1159

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
30d5f45
Release 2.9.2 notes and version bump
peterbarker Mar 14, 2019
d798acc
Bugfix - sometimes removing already gotten parameters from params_set
DawidKopec94 Jul 8, 2022
5f59976
Merge branch 'master' into received_params
DawidKopec94 Jul 8, 2022
de06765
change length of params_set in params loader listener
DawidKopec94 Mar 8, 2023
0d12795
LongDescription
DawidKopec94 Mar 8, 2023
2f3f7b0
add comments and debug message
DawidKopec94 Mar 8, 2023
686a342
auto update test
DawidKopec94 Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bugfix - sometimes removing already gotten parameters from params_set
  • Loading branch information
@DawidKopec94
DawidKopec94 committed Jul 8, 2022
commit d798accc4a98ac0593f910202a68b02db7c5f16a
13 changes: 9 additions & 4 deletions dronekit/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,13 +1320,18 @@ def listener(_):

@self.on_message(['PARAM_VALUE'])
def listener(self, name, msg):
# If we discover a new param count, assume we
# are receiving a new param set.
# If we discover a new params count,
# we are modify length of params set
if self._params_count != msg.param_count:
self._params_loaded = False
self._params_start = True
self._params_count = msg.param_count
self._params_set = [None] * msg.param_count

diff = self._params_count - len(self._params_set)
if diff > 0:
self._params_set += [None] * diff
else:
self._params_set[:diff]

# Attempt to set the params. We throw an error
# if the index is out of range of the count or
Expand Down Expand Up @@ -2544,7 +2549,7 @@ def listener(vehicle, name, m):

@vehicle.on_message('MOUNT_ORIENTATION')
def listener(vehicle, name, m):
self._pitch = m.pitch
self._pitch = m.pitch
self._roll = m.roll
self._yaw = m.yaw
vehicle.notify_attribute_listeners('gimbal', vehicle.gimbal)
Expand Down