Skip to content

append extension methods in GetRelevantMethodsForTrait #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 1 commit into from
Mar 15, 2019
Merged

append extension methods in GetRelevantMethodsForTrait #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/fsharp/ConstraintSolver.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,6 +1536,17 @@ and GetRelevantMethodsForTrait (csenv:ConstraintSolverEnv) permitWeakResolution
// We merge based on whether minfos use identical metadata or not.
let minfos = List.reduce (ListSet.unionFavourLeft MethInfo.MethInfosUseIdenticalDefinitions) minfos

// Get the extension method that may be relevant to solving the constraint as MethInfo objects.
// Extension members are not used when canonicalizing prior to generalization (permitWeakResolution=true)
let extMInfos =
if MemberConstraintSupportIsReadyForDeterminingOverloads csenv traitInfo then
GetRelevantExtensionMethodsForTrait csenv.m csenv.amap traitInfo
else []

let extMInfos = extMInfos |> ListSet.setify MethInfo.MethInfosUseIdenticalDefinitions

let minfos = minfos @ extMInfos

/// Check that the available members aren't hiding a member from the parent (depth 1 only)
let relevantMinfos = minfos |> List.filter(fun minfo -> not minfo.IsDispatchSlot && not minfo.IsVirtual && minfo.IsInstance)
minfos
Expand Down