Mark error constructors cold #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All `#[cold]` to all error constructors. As discussed in the [issue dtolnay#165](dtolnay#165), marking functions cold helps LLVM optimize code paths not leading to error. Although in our case marking only `from` was enough, I took the liberty of marking all error constructors `#[cold]`. Note, I marked cold both inner function and public functions, because LLVM does not always takes into account `#[cold]` attribute of inlined functions, see [an example in compiled explorer](https://rust.godbolt.org/z/vzxazMMnb).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
#[cold]to all error constructors.As discussed in the issue #165,
marking functions cold helps LLVM optimize code paths not leading to error.
Although in our case marking only
fromwas enough, I took theliberty of marking all error constructors
#[cold].Note, I marked cold both inner function and public functions, because
LLVM does not always takes into account
#[cold]attribute of inlined functions,see an example in compiled explorer.