build: Remove datadir argument from start command

[dvanoni]

Summary by CodeRabbit

• Chores
  • Refined startup configuration parameters to streamline application initialization and debug mode handling based on version type.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The scripts/start.mts file was modified to update the getZoteroArgs function. The initial arguments array passed to Zotero now contains only ['-ZoteroDebugText'], with the previously included -datadir and profile arguments removed. The conditional logic for adding debug-related flags based on the version type (beta/dev versus others) remains unchanged.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing the datadir argument from the start command, which is exactly what the file modifications show in getZoteroArgs.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch start-datadir

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0e6e80 and f45de27.

📒 Files selected for processing (1)

• scripts/start.mts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

scripts/start.mts (2)

types/zotero.d.ts (1)

• Zotero (477-543)

src/content/utils/logger.ts (1)

• zoteroDebug (64-69)

🔇 Additional comments (1)

scripts/start.mts (1)

55-65: The -datadir removal is intentional and properly handled through web-ext's firefoxProfile parameter.

The profile path is correctly configured via zotero.config.json (line 91: getProfilePath()), then passed to web-ext's cmd.run() using the firefoxProfile parameter (line 109). This is the standard and recommended approach when using web-ext to manage Firefox/Zotero profiles, delegating profile configuration to web-ext's native API rather than relying on command-line arguments. The README documents this as the proper development setup method.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🤖 Build Bot

✅ Successful build

⬇️ Download: notero-1.2.2-936