initial connection to Dynatrace Tenant Validation #79
Conversation
premrajvs
requested review from
christian-kreuzberger-dtx,
krisdyna,
MrManny and
raphael-wigoutschnigg-dt
as code owners
There was a problem hiding this comment.
I am wondering if we should also incorporate some aspects we've seen in real-life, specifically #33. It would mean test-querying Grail though, which may incur cost. If something like that is added, maybe we should formulate the instruction in a manner that will only call the tool if the user specifically asks for it?
WDYT?
|
That is an interesting thought and I agree it will help the users. I will take that as an action item for a separate feature branch. However, this PR is strictly for one reason. To help users confirm - Is the MCP Server connecting to Dynatrace tenant ? because in Enterprise environments teams deploy MCP servers on a private instance and may have to allow the traffic via firewall to the tenant. This code change will help users confirm if their MCP server is connected to their respective tenant. |
|
Fair :) |
|
@christian-kreuzberger-dtx Can you please merge the changes to main branch |
|
Please hang tight, I'll verify those changes today and get them merged. Thanks for your patience! |
… env tool subscription 2) added handleClientRequestError utility function to handle errors 3) added a rety logic to testconnection and avoid endless loop
…ajvs/dynatrace-mcp into check-connection-to-tenant
|
@christian-kreuzberger-dtx Thank you for taking the time to share your feedback. I made the recommended changes. Please review and do the needful. |
christian-kreuzberger-dtx
merged commit 32d7a2d
into
dynatrace-oss:main
I added a function that gets invoked when the MCP Server starts for the first time to test the connection with Dynatrace Tenant. I also added a tool with the ability to test connection.
I tested the code with prettier function as well.
I tested the changes by starting the MCP Server with incorrect credentials and it returned error. I also tested the changes by deploying the MCP Server in a server that cannot access Dynatrace tenant and it returned error.
In actual enterprise environment, these changes will help users launch MCP Servers and validate the connectivity with tenant.