Skip to content

fix(deps): update bincode requirement from 1.3.3 to 2.0.1 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(deps): update bincode requirement from 1.3.3 to 2.0.1 #15

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
32be1a0
fix(deps): update bincode requirement from 1.3.3 to 2.0.1
dependabot[bot] Mar 10, 2025
8c7e25c
Attempt to migrate to Bincode 2.0.1
ScottGibb Apr 10, 2025
31b4d18
Merge branch 'main' into dependabot/cargo/bincode-2.0.1
ScottGibb Apr 10, 2025
9d4d968
trying to bypass the size
ScottGibb Apr 10, 2025
41c3d6a
revert
ScottGibb Apr 10, 2025
2e1caec
Merge branch 'main' into dependabot/cargo/bincode-2.0.1
ScottGibb Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert
  • Loading branch information
@ScottGibb
ScottGibb committed Apr 10, 2025
commit 41c3d6a3b75a9d9abdfa787d3132b695a79a9093
13 changes: 5 additions & 8 deletions src/rtde/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,16 +110,13 @@ where
if let Some(size) = set_size {
payload.header.package_size = size;
Ok(payload)
} else {
} else if let Ok(size) = bincode::serialized_size(&payload) {
// TODO: Currently Not imleted in Bincode 2 ^
payload.header.package_size = size as u16;
Ok(payload)
} else {
Err(Error::Static("issue setting payload size"))
}
// } else if let Ok(size) = bincode::serialized_size(&payload) {
// // TODO: Currently Not imleted in Bincode 2 ^
// payload.header.package_size = size as u16;
// Ok(payload)
// } else {
// Err(Error::Static("issue setting payload size"))
// }
}
/// What type of Payload package do we have?
pub fn get_type(&self) -> PackageType {
Expand Down
Loading