Fix UT: address UAF in TestRaftLogStore lifecycle_test under ASan#860
Open
Besroy wants to merge 1 commit intoeBay:masterfrom
Open
Fix UT: address UAF in TestRaftLogStore lifecycle_test under ASan#860Besroy wants to merge 1 commit intoeBay:masterfrom
Besroy wants to merge 1 commit intoeBay:masterfrom
Conversation
This change restore pending callback tracking in LogDev::on_flush_completion to fix the UT TestRaftLogStore.lifecycle_test UAF issue.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #860 +/- ##
==========================================
- Coverage 56.51% 48.40% -8.12%
==========================================
Files 108 110 +2
Lines 10300 12857 +2557
Branches 1402 6170 +4768
==========================================
+ Hits 5821 6223 +402
+ Misses 3894 2544 -1350
- Partials 585 4090 +3505 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| auto ld_key = logdev_key{idx, dev_offset}; | ||
| auto comp_cb = req->log_store->get_comp_cb(); | ||
| (req->cb) ? req->cb(req, ld_key) : comp_cb(req, ld_key); | ||
| m_pending_callback--; |
Contributor
There was a problem hiding this comment.
m_pending_callback += req_map.size();
for(....){
}
m_pending_callback = 0;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change restore pending callback tracking in LogDev::on_flush_completion to fix the UT TestRaftLogStore.lifecycle_test UAF issue.