Skip to content

Conversation

@line-o
Copy link
Member

@line-o line-o commented Jan 25, 2020

Description:

Original from @sten1ee :
In our usage of eXist, we're utilising a 'State of the art' LuceneAnalyzer for Sanskrit language developed by our colleagues from BDRC It has several modes of operation, but the one that we use - 'lenient mode' - requires one Analyzer to be used during the indexing phase, but then a different (or a differently configured) one to be used during querying.
Currently, eXist does not provide support for this use case, but this PR is aiming to achieve this feat.

  • rebased on current develop
  • tests for full-text indices
  • tests for fields
  • tests for new Lucene fields
  • documentation

Reference:

based on #2908, #2991 opened by @sten1ee

Type of tests:

testsuite in XML

@sten1ee
Copy link
Contributor

sten1ee commented Feb 11, 2020

@line-o : how's it going with the additional tests and the documentation of the feature?

@line-o
Copy link
Member Author

line-o commented Feb 11, 2020

@sten1ee the tests are part of this PR - documentation is still TODO (see the checkboxes in the description)

@line-o
Copy link
Member Author

line-o commented Feb 11, 2020

@sten1ee would you be able to describe your use-case in the referenced documentation ticket. A link to the indexer and a code example would be great, too.

@line-o line-o added the needs documentation Signals issues or PRs that will require an update to the documentation repo label Feb 11, 2020
@sten1ee
Copy link
Contributor

sten1ee commented Feb 15, 2020

There's some documentation, (who volunteers to review it?):
eXist-db/documentation#445

@sten1ee
Copy link
Contributor

sten1ee commented Feb 25, 2020

The corresponding docs PR#445 was approved and merged.
So perhaps it is about time to approve and merge this too, @adamretter ? :)

@adamretter
Copy link
Contributor

@sten1ee @line-o I think this one has to be reviewed by @wolfgangmm instead of me, as how the Lucene stuff works in eXist-db is his domain.

Copy link
Member

@wolfgangmm wolfgangmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to the additional tests @line-o provided, I'm entirely happy with this PR now. Thanks!

@wolfgangmm wolfgangmm merged commit b3091f9 into eXist-db:develop Mar 2, 2020
@line-o line-o deleted the feat/distinct-query-analyzer branch November 26, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs documentation Signals issues or PRs that will require an update to the documentation repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants