Cleanup all module contexts #3897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as not enforced in eXist-db, and so accidentally internally xs:integer was being used. This has now been corrected
adamretter
force-pushed
the
bugfix/close-sql-connection-from-library-module
branch
from
f346c75 to
8ccc301
Compare
38 tasks
…ly called on each SQL Connection. See eXist-db#3889
context, this meant that not all resources stored in context variables were correctly cleaned up, therefore leaking resources and memory. In addition reset was previously called more than once for the same module which was unecessary. Closes eXist-db#3889
adamretter
force-pushed
the
bugfix/close-sql-connection-from-library-module
branch
from
29f2207 to
7f04fc9
Compare
adamretter
changed the title
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3889
Previously Library Modules were reset with the wrong context, i.e. they were provided with the Main Module's context and not the Library Module's Context.
This meant that not all resources stored in context variables were correctly cleaned up, therefore leaking resources and memory. In addition reset was previously called more than once for the same module which was unnecessary; therefore we should also see a small performance improvement from this fix.
Many thanks to @xatapult and @PieterLamers for their patience in reporting this and helping to track down the issue.
As a result all SQL Connections should now also be correctly and implicitly closed when a query finishes execution.