Skip to content

Conversation

@adamretter
Copy link
Contributor

@adamretter adamretter commented Jun 18, 2021

Update to Apache XML-RPC with latest Security Patches from Evolved Binary.
Addresses CVE-2019-17570 and CVE-2016-5002

Note - This PR changes XML-RPC API (and therefore also the XML:DB remote API).

Previously eXist-db was relying on the in-built Java Serialization for communicating ACL's, unfortunately that facility is inherently insecure. This PR now adds a custom XML-RPC Serializer and Parser for ACLs to ensure this is secure; the upshot is that the wire-protocol has to change to support this. This means users of the XML-RPC and XML:DB APIs (e.g. Java Admin Client, oXygen XML Editor, etc) will need to upgrade their libraries as this is not backwards compatible.

Closes #3063

@adamretter adamretter added bug issue confirmed as bug security labels Jun 18, 2021
@adamretter adamretter added this to the eXist-6.0.0 milestone Jun 18, 2021
@adamretter adamretter requested a review from a team June 18, 2021 14:54
@adamretter adamretter force-pushed the security/update-apache-xmlrpc branch from 2e6a12c to ed8ca86 Compare June 18, 2021 14:56
@line-o
Copy link
Member

line-o commented Jun 18, 2021

@adamretter Many thanks for this contribution.
I would like to know if this might have implications to other XML-RPC clients communicating with exist (e.g. gulp-exist).

Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will approve after a local test.

@adamretter
Copy link
Contributor Author

adamretter commented Jun 18, 2021

I would like to know if this might have implications to other XML-RPC clients communicating with exist (e.g. gulp-exist).

@line-o I can't say. I don't know gulp-exist or what it does or how it works, the author of that should be able to tell you.

@sonarqubecloud
Copy link

@line-o line-o added the dependencies Pull requests that update a dependency file label Jun 21, 2021
@adamretter adamretter force-pushed the security/update-apache-xmlrpc branch from ed8ca86 to 13efbf1 Compare January 23, 2022 07:31
… Evolved Binary. Addresses CVE-2019-17570 and CVE-2016-5002

Note - this does change the XML-RPC API (and therefore also the XML:DB remote API) where ACL's are communicated
Closes eXist-db#3063
@adamretter adamretter force-pushed the security/update-apache-xmlrpc branch from 13efbf1 to cf74509 Compare January 25, 2022 00:19
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
6.2% 6.2% Duplication

@dizzzz dizzzz merged commit 0e9841c into eXist-db:develop Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug issue confirmed as bug dependencies Pull requests that update a dependency file security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apache XML-RPC CVE-2016-5002

3 participants