Skip to content

Switch to the new templating module #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
line-o merged 8 commits into from
Jun 7, 2021
Merged

Switch to the new templating module #41

line-o merged 8 commits into from
Jun 7, 2021

Conversation

@joewiz
Copy link
Member

@joewiz joewiz commented Jun 4, 2021

In preparation for release of eXist 5.3.0 - see eXist-db/exist#3914.

@joewiz
Copy link
Member Author

joewiz commented Jun 4, 2021

As with the corresponding PR for the documentation app - eXist-db/documentation#626 - this PR produces a 400 error on the landing page:

err:XPTY0004 Invalid cardinality for parameter $action. Expected exactly one, got 0 [at line 86, column 20, source: /db/apps/fundocs/modules/app.xql]
In function:
	app:action(node(), map(*), xs:string, xs:string?, xs:string?, xs:string) [-1:-1:/db/apps/fundocs/modules/app.xql]
	templates:process-output(element(), map(*), item()*, element(function)) [211:9:/Users/joe/Library/Application Support/org.exist/expathrepo/shared-0.9.1/content/templates.xql]
	templates:call-by-introspection(element(), map(*), map(*), function(*)) [189:28:/Users/joe/Library/Application Support/org.exist/expathrepo/shared-0.9.1/content/templates.xql]
	templates:call(item(), element(), map(*)) [145:37:/Users/joe/Library/Application Support/org.exist/expathrepo/shared-0.9.1/content/templates.xql]
	templates:process(node()*, map(*)) [148:81:/Users/joe/Library/Application Support/org.exist/expathrepo/shared-0.9.1/content/templates.xql]
	templates:process(node()*, map(*)) [148:81:/Users/joe/Library/Application Support/org.exist/expathrepo/shared-0.9.1/content/templates.xql]
	templates:process(node()*, map(*)) [148:81:/Users/joe/Library/Application Support/org.exist/expathrepo/shared-0.9.1/content/templates.xql]
	templates:process(node()*, map(*)) [148:81:/Users/joe/Library/Application Support/org.exist/expathrepo/shared-0.9.1/content/templates.xql]
	templates:process(node()*, map(*)) [20:23:/Users/joe/Library/Application Support/org.exist/expathrepo/shared-0.9.1/content/templates.xql]
	site:expand-links(node(), map(*), xs:string?) [-1:-1:/Users/joe/Library/Application Support/org.exist/expathrepo/shared-0.9.1/content/siteutils.xql]
	templates:process-output(element(), map(*), item()*, element(function)) [210:9:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:call-by-introspection(element(), map(*), map(*), function(*)) [188:28:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:call(item(), element(), map(*)) [144:37:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:process(node()*, map(*)) [147:81:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:process(node()*, map(*)) [430:17:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:process-output(element(), map(*), item()*) [229:9:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:process-output(element(), map(*), item()*, element(function)) [210:9:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:call-by-introspection(element(), map(*), map(*), function(*)) [188:28:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:call(item(), element(), map(*)) [144:37:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:process(node()*, map(*)) [132:51:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:process(node()*, map(*)) [89:9:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]
	templates:apply(node()+, function(*), map(*)?, map(*)?) [24:5:/Users/joe/Library/Application Support/org.exist/expathrepo/templating-1.0.0/content/templates.xqm]

The relevant call to %templates:default is here: https://github.com/eXist-db/function-documentation/blob/master/src/main/xar-resources/modules/app.xql#L83-L85.

@joewiz joewiz mentioned this pull request Jun 4, 2021
Closed
38 tasks
@joewiz
Copy link
Member Author

joewiz commented Jun 6, 2021

We may want to pause on merging this PR until eXist-db/exist#3918 is resolved. The lib:parse-params templating function is affected by this issue.

@line-o line-o self-requested a review June 7, 2021 14:11
line-o
line-o approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see we already depend on 1.0.2
Then, all is fine

@line-o line-o merged commit fbc2a94 into eXist-db:master Jun 7, 2021
@joewiz joewiz deleted the new-templating branch June 7, 2021 14:54
@joewiz
Copy link
Member Author

joewiz commented Jun 7, 2021

@line-o Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@line-o line-o line-o approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joewiz @line-o @wolfgangmm