[feat] replace markdown rendering with marked #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in all modules and - in the code example in index-keys_5.md
Update bootstrap to v3.4.1 and jQuery to 1.12.4 - load all frontend dependencies with npm - automate frontend build in gulpfile - integrate npm and gulp build into maven - remove $shared route from controller - replace ACE editor with prismjs for highlighting code - bundle dbutil module from shared resources - use bundled copy of dbutil in scan module - remove non-existing and unused site module from view.xql - bundle all fonts, images and styles previously included from shared resources package - remove dependency on shared-resources from repo.xml
- rename element with duplicate ID in index.html - scope all function and variables to query.js - refactor function checkLogin for readability and reusability - use reindexIfLoggedIn for both buttons explicitly - fix deprecated method to add event handlers in jQuery
- optimize SVGs powered-by.svg and existdb-web.svg using SVGO - use optimized SVGs in footer and header - remove blurry gif from header - remove header.gif - remove existdb.png
- remove dependency on markdown XAR package - add npm package dependency on marked - refactor XQuery code to only include raw markdown file contents - add code to transform markdown content client-side
- strings in lightblue (similar to the old clouds theme) - apply hacky inline-ish css rules only to function signatures
- define file global variables at the beginning - add comment to fix custom debounce implementation
Use `reload()` method to reload the page after successful generation of the function documentation rather than resetting the `href` property to ".".
Tables needed bootstrap specific classes to be set in order to be rendered as before.
wolfgangmm
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown content in extended function information is now rendered client-side using
marked.
The dependency on the Markdown package is removed.
The markdown rendering very close to the previous implementation.
There are differences regarding the headline level and the HTML output.
# title-> is now correctly rendered as<h1>title</h1>where it was<h2>title</h2>before.Also no
<section>elements are inserted anymore.depends on #42 to be merged first.