Skip to content

enable running of LAPACK tests for recent OpenBLAS easyconfigs + add patch to fix failing LAPACK tests due to use of -ftree-vectorize #16406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 18, 2022
Merged

enable running of LAPACK tests for recent OpenBLAS easyconfigs + add patch to fix failing LAPACK tests due to use of -ftree-vectorize #16406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8694579
enable running of LAPACK tests for recent OpenBLAS easyconfigs + set …
boegel Oct 14, 2022
abe3ca5
add Python build dependency for OpenBLAS easyconfigs that run LAPACK …
boegel Oct 14, 2022
bb0269a
add patch to fix failing LAPACK tests due to -ftree-vectorize + lower…
boegel Oct 17, 2022
c474ce7
increase max. number of failing LAPACK tests with numerical error to …
boegel Oct 17, 2022
3f8a3ed
increase max. number of failing LAPACK tests with numerical error a b…
boegel Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.17-GCC-11.2.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,29 @@ patches = [
'OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch',
'OpenBLAS-%(version)s_workaround-gcc11-miscompiling-C-ZBLAS3-tests.patch',
'OpenBLAS-%(version)s_fix-segfault-ztrsv.patch',
'OpenBLAS-0.3.21_fix-order-vectorization.patch',
]
checksums = [
'df2934fa33d04fd84d839ca698280df55c690c86a5a1133b3f7266fce1de279f', # v0.3.17.tar.gz
'f328d88b7fa97722f271d7d0cfea1c220e0f8e5ed5ff01d8ef1eb51d6f4243a1', # large.tgz
'999c65f8ea8bd4eac7f1c7f3463d4946917afd20a997807300fe35d70122f3af', # timing.tgz
# OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch
'e6b326fb8c4a8a6fd07741d9983c37a72c55c9ff9a4f74a80e1352ce5f975971',
# OpenBLAS-0.3.17_workaround-gcc11-miscompiling-C-ZBLAS3-tests.patch
'ea76320bc047eff1bf2a2f50c1c19acb4fd6d2b8a5bf81a4dce73145a2a5cfcb',
'b1f89d90cc46b486534069135854e6081994b5a1a88370d32dae982e0f040111', # OpenBLAS-0.3.17_fix-segfault-ztrsv.patch
{'v0.3.17.tar.gz': 'df2934fa33d04fd84d839ca698280df55c690c86a5a1133b3f7266fce1de279f'},
{'large.tgz': 'f328d88b7fa97722f271d7d0cfea1c220e0f8e5ed5ff01d8ef1eb51d6f4243a1'},
{'timing.tgz': '999c65f8ea8bd4eac7f1c7f3463d4946917afd20a997807300fe35d70122f3af'},
{'OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch':
'e6b326fb8c4a8a6fd07741d9983c37a72c55c9ff9a4f74a80e1352ce5f975971'},
{'OpenBLAS-0.3.17_workaround-gcc11-miscompiling-C-ZBLAS3-tests.patch':
'ea76320bc047eff1bf2a2f50c1c19acb4fd6d2b8a5bf81a4dce73145a2a5cfcb'},
{'OpenBLAS-0.3.17_fix-segfault-ztrsv.patch': 'b1f89d90cc46b486534069135854e6081994b5a1a88370d32dae982e0f040111'},
{'OpenBLAS-0.3.21_fix-order-vectorization.patch':
'08af834e5d60441fd35c128758ed9c092ba6887c829e0471ecd489079539047d'},
]

builddependencies = [
# required by LAPACK test suite
('Python', '3.9.6', '-bare'),
]

run_lapack_tests = True
max_failing_lapack_tests_num_errors = 150

# extensive testing can be enabled by uncommenting the line below
# runtest = 'PATH=.:$PATH lapack-timing'

Expand Down
23 changes: 17 additions & 6 deletions easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.18-GCC-11.2.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,27 @@ patches = [
('timing.tgz', '.'),
'OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch',
'OpenBLAS-0.3.17_fix-segfault-ztrsv.patch',
'OpenBLAS-0.3.21_fix-order-vectorization.patch',
]
checksums = [
'1632c1e8cca62d8bed064b37747e331a1796fc46f688626337362bf0d16aeadb', # v0.3.18.tar.gz
'f328d88b7fa97722f271d7d0cfea1c220e0f8e5ed5ff01d8ef1eb51d6f4243a1', # large.tgz
'999c65f8ea8bd4eac7f1c7f3463d4946917afd20a997807300fe35d70122f3af', # timing.tgz
# OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch
'e6b326fb8c4a8a6fd07741d9983c37a72c55c9ff9a4f74a80e1352ce5f975971',
'b1f89d90cc46b486534069135854e6081994b5a1a88370d32dae982e0f040111', # OpenBLAS-0.3.17_fix-segfault-ztrsv.patch
{'v0.3.18.tar.gz': '1632c1e8cca62d8bed064b37747e331a1796fc46f688626337362bf0d16aeadb'},
{'large.tgz': 'f328d88b7fa97722f271d7d0cfea1c220e0f8e5ed5ff01d8ef1eb51d6f4243a1'},
{'timing.tgz': '999c65f8ea8bd4eac7f1c7f3463d4946917afd20a997807300fe35d70122f3af'},
{'OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch':
'e6b326fb8c4a8a6fd07741d9983c37a72c55c9ff9a4f74a80e1352ce5f975971'},
{'OpenBLAS-0.3.17_fix-segfault-ztrsv.patch': 'b1f89d90cc46b486534069135854e6081994b5a1a88370d32dae982e0f040111'},
{'OpenBLAS-0.3.21_fix-order-vectorization.patch':
'08af834e5d60441fd35c128758ed9c092ba6887c829e0471ecd489079539047d'},
]

builddependencies = [
# required by LAPACK test suite
('Python', '3.9.6', '-bare'),
]

run_lapack_tests = True
max_failing_lapack_tests_num_errors = 150

# extensive testing can be enabled by uncommenting the line below
# runtest = 'PATH=.:$PATH lapack-timing'

Expand Down
21 changes: 16 additions & 5 deletions easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.20-GCC-11.2.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,26 @@ patches = [
('large.tgz', '.'),
('timing.tgz', '.'),
'OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch',
'OpenBLAS-0.3.21_fix-order-vectorization.patch',
]
checksums = [
'8495c9affc536253648e942908e88e097f2ec7753ede55aca52e5dead3029e3c', # v0.3.20.tar.gz
'f328d88b7fa97722f271d7d0cfea1c220e0f8e5ed5ff01d8ef1eb51d6f4243a1', # large.tgz
'999c65f8ea8bd4eac7f1c7f3463d4946917afd20a997807300fe35d70122f3af', # timing.tgz
# OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch
'e6b326fb8c4a8a6fd07741d9983c37a72c55c9ff9a4f74a80e1352ce5f975971',
{'v0.3.20.tar.gz': '8495c9affc536253648e942908e88e097f2ec7753ede55aca52e5dead3029e3c'},
{'large.tgz': 'f328d88b7fa97722f271d7d0cfea1c220e0f8e5ed5ff01d8ef1eb51d6f4243a1'},
{'timing.tgz': '999c65f8ea8bd4eac7f1c7f3463d4946917afd20a997807300fe35d70122f3af'},
{'OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch':
'e6b326fb8c4a8a6fd07741d9983c37a72c55c9ff9a4f74a80e1352ce5f975971'},
{'OpenBLAS-0.3.21_fix-order-vectorization.patch':
'08af834e5d60441fd35c128758ed9c092ba6887c829e0471ecd489079539047d'},
]

builddependencies = [
# required by LAPACK test suite
('Python', '3.9.6', '-bare'),
]

run_lapack_tests = True
max_failing_lapack_tests_num_errors = 150

# extensive testing can be enabled by uncommenting the line below
# runtest = 'PATH=.:$PATH lapack-timing'

Expand Down
21 changes: 16 additions & 5 deletions easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.20-GCC-11.3.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,26 @@ patches = [
('large.tgz', '.'),
('timing.tgz', '.'),
'OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch',
'OpenBLAS-0.3.21_fix-order-vectorization.patch',
]
checksums = [
'8495c9affc536253648e942908e88e097f2ec7753ede55aca52e5dead3029e3c', # v0.3.20.tar.gz
'f328d88b7fa97722f271d7d0cfea1c220e0f8e5ed5ff01d8ef1eb51d6f4243a1', # large.tgz
'999c65f8ea8bd4eac7f1c7f3463d4946917afd20a997807300fe35d70122f3af', # timing.tgz
# OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch
'e6b326fb8c4a8a6fd07741d9983c37a72c55c9ff9a4f74a80e1352ce5f975971',
{'v0.3.20.tar.gz': '8495c9affc536253648e942908e88e097f2ec7753ede55aca52e5dead3029e3c'},
{'large.tgz': 'f328d88b7fa97722f271d7d0cfea1c220e0f8e5ed5ff01d8ef1eb51d6f4243a1'},
{'timing.tgz': '999c65f8ea8bd4eac7f1c7f3463d4946917afd20a997807300fe35d70122f3af'},
{'OpenBLAS-0.3.15_workaround-gcc-miscompilation.patch':
'e6b326fb8c4a8a6fd07741d9983c37a72c55c9ff9a4f74a80e1352ce5f975971'},
{'OpenBLAS-0.3.21_fix-order-vectorization.patch':
'08af834e5d60441fd35c128758ed9c092ba6887c829e0471ecd489079539047d'},
]

builddependencies = [
# required by LAPACK test suite
('Python', '3.10.4', '-bare'),
]

run_lapack_tests = True
max_failing_lapack_tests_num_errors = 150

# extensive testing can be enabled by uncommenting the line below
# runtest = 'PATH=.:$PATH lapack-timing'

Expand Down
43 changes: 43 additions & 0 deletions easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.21_fix-order-vectorization.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
add parentheses to force a certain order that is compatible with non-FMA instructions;
fixes failing LAPACK tests when -ftree-vectorize is used
author: Bart Oldeman (Digital Research Alliance of Canada)
--- OpenBLAS-0.3.21/lapack-netlib/SRC/clahqr.f.orig 2022-08-07 20:36:26.000000000 +0000
+++ OpenBLAS-0.3.21/lapack-netlib/SRC/clahqr.f 2022-10-15 02:56:05.646906448 +0000
@@ -484,7 +484,7 @@
* in columns K to I2.
*
DO 80 J = K, I2
- SUM = CONJG( T1 )*H( K, J ) + T2*H( K+1, J )
+ SUM = CONJG( T1 )*H( K, J ) + ( T2*H( K+1, J ) )
H( K, J ) = H( K, J ) - SUM
H( K+1, J ) = H( K+1, J ) - SUM*V2
80 CONTINUE
@@ -493,7 +493,7 @@
* matrix in rows I1 to min(K+2,I).
*
DO 90 J = I1, MIN( K+2, I )
- SUM = T1*H( J, K ) + T2*H( J, K+1 )
+ SUM = T1*H( J, K ) + ( T2*H( J, K+1 ) )
H( J, K ) = H( J, K ) - SUM
H( J, K+1 ) = H( J, K+1 ) - SUM*CONJG( V2 )
90 CONTINUE
--- OpenBLAS-0.3.21/lapack-netlib/SRC/zlahqr.f.orig 2022-08-07 20:36:26.000000000 +0000
+++ OpenBLAS-0.3.21/lapack-netlib/SRC/zlahqr.f 2022-10-15 02:11:54.111966029 +0000
@@ -484,7 +484,7 @@
* in columns K to I2.
*
DO 80 J = K, I2
- SUM = DCONJG( T1 )*H( K, J ) + T2*H( K+1, J )
+ SUM = DCONJG( T1 )*H( K, J ) + ( T2*H( K+1, J ) )
H( K, J ) = H( K, J ) - SUM
H( K+1, J ) = H( K+1, J ) - SUM*V2
80 CONTINUE
@@ -493,7 +493,7 @@
* matrix in rows I1 to min(K+2,I).
*
DO 90 J = I1, MIN( K+2, I )
- SUM = T1*H( J, K ) + T2*H( J, K+1 )
+ SUM = T1*H( J, K ) + ( T2*H( J, K+1 ) )
H( J, K ) = H( J, K ) - SUM
H( J, K+1 ) = H( J, K+1 ) - SUM*DCONJG( V2 )
90 CONTINUE