Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Nov 9, 2022

@boegel boegel added the update label Nov 9, 2022
@boegel boegel added this to the next release (4.6.3?) milestone Nov 9, 2022
@boegel boegel mentioned this pull request Nov 9, 2022
@boegel
Copy link
Member Author

boegel commented Nov 9, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3135.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/ec71922a9a3838ee5b8110939c456201 for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 9, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16602 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16602 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9486

Test results coming soon (I hope)...

- notification for comment with ID 1309434846 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

boegelbot commented Nov 9, 2022

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 3 (3 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/cd2f7714872ba15083eec16163913b58 for a full test report.

			-->   LAPACK TESTING SUMMARY  <--
SUMMARY             	nb test run 	numerical error   	other error  
================   	===========	=================	================  
REAL             	1317867		0	(0.000%)	0	(0.000%)	
DOUBLE PRECISION	1318689		0	(0.000%)	0	(0.000%)	
COMPLEX          	769171		180	(0.023%)	0	(0.000%)	
COMPLEX16         	769982		99	(0.013%)	0	(0.000%)	

--> ALL PRECISIONS	4175709		279	(0.007%)	0	(0.000%)	

@branfosj
Copy link
Member

branfosj commented Nov 9, 2022

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/2a2bd588a730046103125c7240737c04 for a full test report.

            -->   LAPACK TESTING SUMMARY  <--
SUMMARY                 nb test run     numerical error     other error  
================    =========== =================   ================  
REAL                1317867     0   (0.000%)    0   (0.000%)    
DOUBLE PRECISION    1317597     10  (0.001%)    0   (0.000%)    
COMPLEX             774343      24  (0.003%)    0   (0.000%)    
COMPLEX16           776246      14  (0.002%)    0   (0.000%)    

--> ALL PRECISIONS  4186053     48  (0.001%)    0   (0.000%) 

@easybuilders easybuilders deleted a comment from boegelbot Nov 9, 2022
@boegel
Copy link
Member Author

boegel commented Nov 9, 2022

@boegelbot please test @ jsc-zen2

@branfosj
Copy link
Member

branfosj commented Nov 9, 2022

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux Ubuntu 20.04.2 LTS (Focal Fossa), x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/5817753b642b309a3e064d66f9105d48 for a full test report.

            -->   LAPACK TESTING SUMMARY  <--
SUMMARY                 nb test run     numerical error     other error  
================    =========== =================   ================  
REAL                1317867     0   (0.000%)    0   (0.000%)    
DOUBLE PRECISION    1317597     9   (0.001%)    0   (0.000%)    
COMPLEX             774343      22  (0.003%)    0   (0.000%)    
COMPLEX16           776246      14  (0.002%)    0   (0.000%)    

--> ALL PRECISIONS  4186053     45  (0.001%)    0   (0.000%)

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16602 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16602 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1759

Test results coming soon (I hope)...

- notification for comment with ID 1309485571 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

boegelbot commented Nov 9, 2022

Test report by @boegelbot
FAILED
Build succeeded for 6 out of 8 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/1f003936543cd9139d2053791e05ce93 for a full test report.

			-->   LAPACK TESTING SUMMARY  <--
SUMMARY             	nb test run 	numerical error   	other error  
================   	===========	=================	================  
REAL             	1317867		0	(0.000%)	0	(0.000%)	
DOUBLE PRECISION	1318689		0	(0.000%)	0	(0.000%)	
COMPLEX          	769171		180	(0.023%)	0	(0.000%)	
COMPLEX16         	769982		99	(0.013%)	0	(0.000%)	

--> ALL PRECISIONS	4175709		279	(0.007%)	0	(0.000%)	

@boegel
Copy link
Member Author

boegel commented Nov 10, 2022

Hmm, I need to check whether the patch from #16406 is also required here...

edit:
All patches (from #16406 + #16510) are already used here, yet we're still seeing more failing tests than expected...

The GCCcore/12.2.0 installations on both generoso and jsc-zen2 were also rebuilt with the patch included in #16411, so that's fine too.

@branfosj
Copy link
Member

branfosj commented Nov 10, 2022

Test report by @branfosj
FAILED
Build succeeded for 8 out of 10 (3 easyconfigs in total)
bear-pg0210u06a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) CPU E5-2640 v4 @ 2.40GHz (broadwell), Python 3.6.8
See https://gist.github.com/5b24b879588401a2eb45da93a1930281 for a full test report.

            -->   LAPACK TESTING SUMMARY  <--
SUMMARY                 nb test run     numerical error     other error
================    =========== =================   ================
REAL                1317867     0   (0.000%)    0   (0.000%)
DOUBLE PRECISION    1318689     0   (0.000%)    0   (0.000%)
COMPLEX             769171      180 (0.023%)    0   (0.000%)
COMPLEX16           769982      99  (0.013%)    0   (0.000%)

--> ALL PRECISIONS  4175709     279 (0.007%)    0   (0.000%)

@boegel
Copy link
Member Author

boegel commented Nov 10, 2022

Test report by @boegel
FAILED
Build succeeded for 29 out of 31 (3 easyconfigs in total)
node2672.swalot.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/bf649421627bb232fd20e95beb08ef85 for a full test report.

@bartoldeman
Copy link
Contributor

A few of these tests are failing due to picky LAPACK tests.
There are a few ways around this:

  1. Increase threshold (duh)
  2. Patch LAPACK a bit more with some brackets, see Many test failures when compiled with -march=haswell -ftree-vectorize Reference-LAPACK/lapack#732 (two of the files are already patched but a few more changes were needed with the updated LAPACK in OpenBLAS 0.3.21)
  3. Disable FMA (-ffp-contract=off) or vectorization for LAPACK (FMA is cheaper to disable here, since vectorization can give more speedup).
    I looked a bit more into the why and it's really about complex multiplication:
    (a+bi)*(c+di)=(a*c-b*d)+i*(a*d+b*c)
    without FMA this always gives the same answer numerically, and for complex conjugates (a+bi)*(a-bi) the resulting imaginary part is exactly zero.

But with FMAs there are 4 permutations possible (e.g. a*d+b*c -> FMA(a,d,b*c) or FMA(b,c,a*d)) and GCC sometimes uses one variation in the vectorized loop and another one in the unvectorized loop (used for the tail ends).

@boegel
Copy link
Member Author

boegel commented Nov 10, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
fair-mastodon-c6g-2xlarge-0001 - Linux Rocky Linux 8.5, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/2cedb0f54950219e8f9b1f87a0fa5353 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jrc0871.jureca - Linux Rocky Linux 8.6, AArch64, ARM UNKNOWN (graviton2), 2 x NVIDIA NVIDIA A100-PCIE-40GB, 515.65.01, Python 3.6.8
See https://gist.github.com/f278dc857456da4b99886b89a9dc0636 for a full test report.

bartoldeman and others added 2 commits November 11, 2022 16:34
For some reason (GCC bug report pending) -ffp-contract=off is not
sufficient for GCC 12, so we also need -mno-fma, implemented via
a GCC pragma.
Adjust disable-fma-in-cscal-zscal.patch for GCC 12
@boegel
Copy link
Member Author

boegel commented Nov 11, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16602 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16602 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9501

Test results coming soon (I hope)...

- notification for comment with ID 1311952862 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bartoldeman
Copy link
Contributor

The OpenBLAS FMA patch was adjusted because of a new issue with GCC 12 (not present in 11.3)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107647
https://godbolt.org/z/aWh6d1E4E

@boegel
Copy link
Member Author

boegel commented Nov 11, 2022

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in total)
node3508.doduo.os - Linux RHEL 8.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/87205938d1f05d7ad3f23c0b6980f20d for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e4406121d3a11cc70b38a12f663624ad for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 11, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
fair-mastodon-c6g-2xlarge-0001 - Linux Rocky Linux 8.5, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/1d49696db11b04030f75b594729a52a9 for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 11, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node2620.swalot.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/b4ecf824e906305dd0f59d9df1cf652c for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 11, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16602 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16602 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1765

Test results coming soon (I hope)...

- notification for comment with ID 1311996431 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/d59278c88854b146105619e1c5f5607b for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 11, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
easybuild2.novalocal - Linux CentOS Stream 8, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/57c0340c1ecd73329326c973738b2858 for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.7, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/fe7d5404f42a1e6a318ee58ffb0f07d3 for a full test report.

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux Ubuntu 20.04.2 LTS (Focal Fossa), x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/53b7cb28697ce3cfffff2bfcbee974d2 for a full test report.

@branfosj
Copy link
Member

Going in, thanks @boegel!

@branfosj branfosj merged commit d77ec0a into easybuilders:develop Nov 12, 2022
@boegel boegel deleted the 20221109215743_new_pr_FlexiBLAS321 branch November 12, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants