Skip to content

Fix "only variables should be passed by reference" PHP notice #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix "only variables should be passed by reference" PHP notice #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix an "only variables should be passed by reference" PHP notice 
The array_walk function accepts the array parameter as reference. That
parameter is being passed directly from the method return however only
variables can be passed as reference.
  • Loading branch information
@rvelhote
rvelhote committed Sep 5, 2018
commit af64433aa3ca33d3c63ab4ac28ef8e8a9c1d8e66
3 changes: 2 additions & 1 deletion app/code/community/Ebanx/Gateway/Block/Health/Check.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ public function hasAnySupportedCurrency()
$this->supportedCurrencies = Currency::all();

try {
array_walk(Mage::app()->getStores(), function ($store) {
$stores = Mage::app()->getStores();
array_walk($stores, function ($store) {
if (in_array(Mage::app()->getStore($store->store_id)->getCurrentCurrencyCode(), $this->supportedCurrencies)) {
throw new Exception;
}
Expand Down