Skip to content

Fix "Only variables should be passed by reference" #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix "Only variables should be passed by reference" #335

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce2b7e8
Fix Only variables should be passed by reference
r-martins Jan 9, 2019
7e07eba
Merge pull request #1 from r-martins/r-martins-fix-333
r-martins Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix Only variables should be passed by reference 
Fix #333 - Only variables should be passed by reference on line 107
  • Loading branch information
@r-martins
r-martins authored Jan 9, 2019
commit ce2b7e88e55de80194be81ed144825638b85de0c
19 changes: 13 additions & 6 deletions app/code/community/Ebanx/Gateway/Block/Health/Check.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,21 @@ public function hasAnySupportedCurrency()
$this->supportedCurrencies = Currency::all();

try {
array_walk(Mage::app()->getStores(), function ($store) {
if (in_array(Mage::app()->getStore($store->store_id)->getCurrentCurrencyCode(), $this->supportedCurrencies)) {
throw new Exception;
$stores = Mage::app()->getStores();
$currentSupportedCurrencies = [];
foreach ($stores as $store) {
$currentCurrencyCode = $store->getCurrentCurrencyCode();
if (in_array($currentCurrencyCode, $this->supportedCurrencies)) {
$currentSupportedCurrencies[] = $currentCurrencyCode;
}
});
} catch (\Exception $e) {
}
if (count($currentSupportedCurrencies) == 0) {
return '<strong>Currency not supported: </strong> Your website must support one of these currencies '
. implode(', ', $this->supportedCurrencies) . '.';;
}
} catch (Exception $e) {
return true;
}
return '<strong>Currency not supported: </strong> Your website must support one of these currencies ' . implode(', ', $this->supportedCurrencies) . '.';
return true;
}
}