Skip to content

Fix an issue with wrong totals when instalments are used #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix an issue with wrong totals when instalments are used #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix an issue with wrong totals when instalments are used 
The setBaseGrandTotal method is set with the interest amount in the
original currency rather than the base currency therefore it has to
be converted to the base currency amount
  • Loading branch information
@rvelhote
rvelhote committed Feb 12, 2019
commit 5fe3b419662b6f300e8fd323c20e7bd768aaf129
2 changes: 1 addition & 1 deletion app/code/community/Ebanx/Gateway/Block/Adminhtml/Sales/Order/Creditmemo/Totals.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ protected function _initTotals()
$this->addTotalBefore(new Varien_Object(array(
'code' => 'ebanx_interest',
'value' => $amount,
'base_value'=> $amount,
'base_value'=> $amount / $this->getOrder()->getBaseToOrderRate(),
'label' => $this->helper('ebanx')->__('Interest Amount'),
), array('tax')));
}
Expand Down
2 changes: 1 addition & 1 deletion app/code/community/Ebanx/Gateway/Block/Adminhtml/Sales/Order/Invoice/Totals.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ protected function _initTotals()
$this->addTotal(new Varien_Object(array(
'code' => 'ebanx_interest',
'value' => $amount,
'base_value'=> $amount,
'base_value'=> $amount / $this->getOrder()->getBaseToOrderRate(),
'label' => $this->helper('ebanx')->__('Interest Amount'),
)));
}
Expand Down
2 changes: 1 addition & 1 deletion app/code/community/Ebanx/Gateway/Block/Adminhtml/Sales/Order/Totals.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ protected function _initTotals()
$this->addTotal(new Varien_Object(array(
'code' => 'ebanx_interest',
'value' => $amount,
'base_value'=> $amount,
'base_value'=> $amount / $this->getOrder()->getBaseToOrderRate(),
'label' => $this->helper('ebanx')->__('Interest Amount'),
), array('tax')));
}
Expand Down
4 changes: 3 additions & 1 deletion app/code/community/Ebanx/Gateway/Model/Quote/Interest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ public function collect(Mage_Sales_Model_Quote_Address $address)
if ($interestAmount > 0) {
$address->setEbanxInterestAmount($interestAmount);
$address->setGrandTotal($address->getGrandTotal() + $interestAmount);
$address->setBaseGrandTotal($address->getBaseGrandTotal() + $interestAmount);
$address->setBaseGrandTotal(
$address->getBaseGrandTotal() + ($interestAmount / $quote->getBaseToQuoteRate())
);
}

return $this;
Expand Down