Skip to content

Add Redux DevTools support #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2019
Merged

Add Redux DevTools support #47

merged 1 commit into from
Nov 29, 2019

Conversation

abraham
Copy link
Contributor

@abraham abraham commented Nov 18, 2019

No description provided.

@sdirix
Copy link
Member

sdirix commented Nov 29, 2019

Thanks for your contribution.

Is there a specific reason to avoid adding redux-devtools-extension as a dependency and using its convenience functions?

@abraham
Copy link
Contributor Author

abraham commented Nov 29, 2019

The only downside that I know of is an additional dependency. It is less code change though.

@sdirix
Copy link
Member

sdirix commented Nov 29, 2019

Thanks! We'll take a look

sdirix
sdirix requested changes Nov 29, 2019
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you solve the merge conflict and remove the empty object?

@abraham
Copy link
Contributor Author

abraham commented Nov 29, 2019

devToolsEnhancer types require an argument.

sdirix
sdirix approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. Thanks!

@sdirix sdirix merged commit d1ad4b9 into eclipsesource:master Nov 29, 2019
@abraham abraham deleted the redux-devtools branch November 29, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abraham @sdirix