fix how we handle empty values #2481
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionalProperties case)
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kchobantonov
changed the title
|
@sdirix please review - when we update the handling of empty values it looks like deleting (not using the x - clear ) was setting the value to empty string rather to remove the property when we are not under dynamic context (e.g. additionalProperties where we need to preserve the key) |
sdirix
reviewed
Sep 22, 2025
| const clearValue = determineClearValue(''); | ||
| return useVuetifyControl(useJsonFormsEnumControl(props), (value) => | ||
| value === null ? clearValue : value, | ||
| value !== null ? value : clearValue, |
| return useVuetifyControl( | ||
| useJsonFormsEnumControl(props), | ||
| (value) => (value === null ? clearValue : value), | ||
| (value) => (value !== null ? value : clearValue), |
There was a problem hiding this comment.
Thinking about it, this behavior is a bit dangerous for all enum related controls. null could be a valid enum value. Why are we not using undefined as the marker for the clearValue again?
| return useVuetifyControl( | ||
| useJsonFormsOneOfEnumControl(props), | ||
| (value) => (value === null ? clearValue : value), | ||
| (value) => (value !== null ? value : clearValue), |
| return useVuetifyControl( | ||
| useJsonFormsEnumControl(props), | ||
| (value) => (value === null ? clearValue : value), | ||
| (value) => (value !== null ? value : clearValue), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix how we handle empty values when not in dynamic context (e.g. addtionalProperties case)