Skip to content

[MOB-4246] Fix first search NTP description width#1082

Merged
lucaschifino merged 1 commit intomainfrom
ls-mob-4246-first-search-description-width-fix
Mar 16, 2026
Merged

[MOB-4246] Fix first search NTP description width#1082
lucaschifino merged 1 commit intomainfrom
ls-mob-4246-first-search-description-width-fix

Conversation

@lucaschifino
Copy link
Copy Markdown
Collaborator

@lucaschifino lucaschifino commented Mar 13, 2026

MOB-4246

Context

Text was cropped on specific language region configurations.

Approach

This was caused by a SwiftUI compression issue when the pills were wider and caused more rows, consuming more vertical space.

To fix it making sure the text doesn't compress vertically.

Other

Before merging

Checklist

  • I performed some relevant testing on a real device and/or simulator for both iPhone and iPad

Copilot AI review requested due to automatic review settings March 13, 2026 14:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Ecosia “First Search” NTP SwiftUI view layout to prevent the description text from being vertically compressed/cropped in locales where the suggestion “pills” wrap into more rows and consume extra vertical space.

Changes:

  • Forces the description Text to keep its intrinsic vertical size by applying .fixedSize(horizontal: false, vertical: true).

You can also share your feedback on Copilot code review. Take the survey.

@lucaschifino lucaschifino requested a review from a team March 13, 2026 14:33
Copy link
Copy Markdown
Member

@d4r1091 d4r1091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 📏

@lucaschifino lucaschifino merged commit 56585ca into main Mar 16, 2026
6 of 7 checks passed
@lucaschifino lucaschifino deleted the ls-mob-4246-first-search-description-width-fix branch March 16, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants