Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for project iOS Release Notes #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Updates for project iOS Release Notes #1088
Changes from 1 commit
b6579ad89694d52f8458be0479fd2ca6c2c10ba68000d0299b3e1a8a12f78a552a445904210d5e07d111e7bfc9656f0e88e5c6be971893a66c94cbcd100b3da337266db90b9dad9ae72dea67b2859d574c0647549a64a7e72df9909d2983871ac531f1bcab0a363500e171d26d3a49214c811ec7a5ac61bb3276f39d244f0cfd62f097dd465230c0080bf9ad6fbeefae98ba2427b0cf2b1ba5359ffa569b83c88986cf06cb9437d1fb9d7691023d570bfe63621e6f7cf468b7ba0222cc1e1694b51cd1bd25b3f3bf429179a2a9f6c3afcbe60604f2a52f093ca8e219b4af6c996b32ff40100e52d62df76b172a34803cb6b959b2589b08bbe032745658ea14fce12ce72b1cbfc0bef721d42d94d3ae4f87d93d45729e815ecda14006d4988699b344973fe967d9dcaa96cf7ec23a56ddda7736a7ee41ce4bf29a931b6d6e1829bd1940984c363f7cfe56b0a0f89513604086f0b8a0f801868db330b9caff5be470db09d2a8dcfe0c226b1763fd23ab2daeeb697ee48e3dc0f97ac4aee34337a88b03959d048d640c249f1241aab3eccf4865ffdf6fa0782b55e4b8b47a8d5e501a19c96ed66b0ea4e7f7b6657b36af03047d48071590796aa1c2439c488f0d729dd6931f8b75d638149019667fe401a5646f69544f694f58b9d9ebab55297bb630e0b25eb8b7766b0f53ce93b4ac6b596d81bb96871d366e3d7c1cf6114a7d492e34aa8e0d5927bca4e4484c0db422dc7b0fd6de8c356afa28fd9844022ec4185c34cee75a63578c99f34d863b4830118dce6b883af47772dbf0b7e234a12ce674c6e3764c6db3cf11e2f5ab3b181702bbba1c543163b9c877bb7d42fc50720724d1f732d3d811049005206c7d70e66119cb034354c508b2ebaf86a87f4ecc782821006668083d2ebf449c92c6ee14a6256166401264bfc467a38808ae1055530f1edf963b41746c5bec11ccb22196cafc72758531eef71f1904364c35d32deec56bde791b071ac58eeef78ef9774af79f6e8d78980896a483f7e098c6f88b91b8e8394b7918c1514fa8843c9216b15b282926751c53c7f4874ba1d9f81c9664d0e888e39ef93b4200b68faf089e87b2d2dcf2912c542e79fc03ded3981362c4d1bc4a5ca3193c89cf001f97886e742e3be45969e651927fd944a4081e8b3d45f807b774011559ddac0e54a20af052b7cd29afe1757c56585ca5dc740715347d6f27d32f88d9c0a3c42edfFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Update configurations Restore `.github`, `.circleci` and `fastlane` Update `bootstrap.sh` Add `Ecosia` folder to project alongside with `Core` Plus: - Adapt `EcosiaTheme` to the new theming - Readd missing `Grey70` - Understood how the new `DynamicFontHelper` work (not notification based anymore) - Remove the extension of `DynamicFontHelper` as not used anymore - Adapt the `private func update()` to the new theming - Add `CredentialProvider` to the list of targets for `EcosiaTheme` and `SemanticColor` Comment Ecosia’s replacement of `FxNimbus` to let the code compile Rename `.theme.ecosia. with the new `.legacyTheme.ecosia` reference Add Ecosia `AccessibilityIdentifiers` Downgrade `SnowplowTracker` version to match our current Ecosia one Version 5.2.0 `NotificationThemeable` to `Themeable` transition - We need to solve `Themeable` protocol so 👇 - Decided to pass to all our Ecosia old `NotificationThemeable` an instance of `ThemeManager = AppContainer.shared.resolve()` - For `notificationCenter = NotifcationCenter.default` Comment the `HomepageViewControllerDelegate` Fix `self.view` -> `self.contentView` Add init extension for `UIEdgeInsets` UI fixes continuation Add `reloadHomepage()` capability to `SettingsDelegate` Add file references from other commit Replace `HomepageSectionType` with `EcosiaHomepageSectionType` file Add `BrowserViewController`'s methods from old ocdebase Update on main class + extensions. Still a lot to be reviewed Update `HomepageSectionType` for customization Add `ContextualHintViewController` extension from old codebase Add `MainMenuActionHelper` extension from old codebase Make `profile` visible outside Fix import Add `ecosiaAppVersion` Add empty body method of `SettingsDelegate` in `SettingsCoordinator` to make it compile Update `getTopSiteURLs` to allow access to the updated sites Remove files from project as not needed Update actions to new approach Fix other themeable stuff Update `shutdown()` method in `Profile` Update NTP ViewModels to the new `HomepageViewModelProtocol` - All NTP view models conforming to `HomepageViewModelProtocol` need to be initialised with `Theme` Update `ToolbarButton` and `CircleButton` Remove `jumpBackIn` section reference Remove Message Card feature Remove History Highlights and Pocket Remove Telemetry section type helper Shows no header for top sites Fix on `HomePageViewModel.shouldDisplayHomeTabBanner` Now Returns a value instead of commenting out the whole computed var Further fixes for Custom UI for FindInPageBar Update MARK NewsSubHeader now conforms to Themeable Add `import Common` to `MMP` Remove `jumpBackIn` section reference Fix `import Common` in Version extension Readd `TableViewColor.accessoryViewTint` Adapt `EcosiaSetting` Add `import Common` to `DefaultAppVersionInfoProvider` Remove `recentlySaved` reference `NTPAboutEcosiaCell` now conforms to Themable Expose `HomepageViewController.viewModel` in extensions Remove `customizeHome` reference Update `HomepageViewModel` with Ecosia's VMs Add Referrals in HomepageViewController Remove `customizeHome` reference n2 Remove `recentlySaved` reference n2 Readd `headerBackground` in TableViewColor Add weak ref of Referrals in HomepageViewController Fix `isNew` for SingleActionViewModel Read `separator` color for TableViewColor Add `isNew` bool n2 Fix `WelcomeTour` Themeing Silence optional `isNew` Review SimpleToast Initialize Referrals Remove `PocketViewModel` reference Remove `FakeSentry` ref from `Client` and assign to `Shared` Temporarily remove `WidgetKitExtension.appex` Temporarily remove `ClearBackgroundView` Remove `referrals` ref in BrowserCoordinator Temporarily remove the `insertData` history implementation Revert "Temporarily remove `WidgetKitExtension.appex`" This reverts commit c3da5c7. Temporarily remove `TopSitesProvider` from `WidgetKitExtension` Add missing entitlements and aligned Configurations Revert "Comment Ecosia’s replacement of `FxNimbus` to let the code compile" This reverts commit 2dea77d. Revert "Revert "Comment Ecosia’s replacement of `FxNimbus` to let the code compile"" This reverts commit 989c26f. Fix `CODE_SIGN_ENTITLEMENTS` Fix build configurations Nimbus fix keeping current implementation Add CredentialProvider Replace AppIcon Rename `xcscheme` from `Fennec` to `Ecosia` App now shows Ecosia onboarding App now shows Ecosia's Launch Screen Completely review view models Register `NTPToolTip` header footer, remove `PocketFooterView` registration Partly implemented `HomePageViewControllerDelegate` Fix App Version Review UICollectionViewDataSource for HomePageViewController HomeLogoHeaderViewModel returns `NTPLogoCell` Update method `refreshData(:)` in `NTPNewsCellViewModel` Add `EcosiaTopSiteItemCell` to replace the standard `TopSiteItemCell` Add Ecosia comment to `HomePageSectionType` All Ecosia's NTP Cells now listens to theme changes Made Ecosia conform to `ThemeColourPalette`. Initial transition Swap Theme Manager with Ecosia's Add custom Ecosia's identifiers Rely on custom Ecosia's identifiers Add `AppInfo+Ecosia.swift` in the Shared module Review `EcosiaThemeColourPalette` Use `EcosiaThemeManager` everywhere Search Bar stays on top by default Change `addNewTabButton` to configurable `CircleButton` Ecosia is the default search engine. Implemented other changes from the Search Experiment. Replace Firefox Support URL with Ecosia FAQ URL Also add the possibility to open a URL in the same tab Restore Bookmarks Empty View Invert Download and Reading list positions in the LibraryViewController Update images as well NTPLogo now respects the intended position NTP updates impact cells correctly Also adds Analytics for Tooltip + Bookmarks card Settings now respect the Ecosia's original action sheet show Correct icons added Settings Icons renders as Template Bugfix FXIOS-7818 [v120.1] Reduce the number of sentry errors (mozilla-mobile#17433) (mozilla-mobile#17435) (cherry picked from commit 2f991d2) Co-authored-by: OrlaM <omitchell@mozilla.com> [7820] Attempt to fix potential issue with tab screenshots not being cleaned up properly. Needs some additional investigation. (mozilla-mobile#17438) (mozilla-mobile#17442) (cherry picked from commit 385859f) Co-authored-by: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com> [7554] Reverts the initial workaround from PR mozilla-mobile#16873; based on current data it appears this may have exacerbated the Close All Tabs crash and so reverting this is expected to help significantly reduce the crash rate for the issue. (mozilla-mobile#17512) (mozilla-mobile#17514) (cherry picked from commit 928f0da) Co-authored-by: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com> Update version for all extensions Add import/export capabilty Bugfix FXIOS-7874 [v120] homepage crash (mozilla-mobile#17577) (mozilla-mobile#17591) * Fix top sites crash * Fix tests (cherry picked from commit 69e65b8) Co-authored-by: OrlaM <omitchell@mozilla.com> Version bump to 9.1.0 (#600) Bump to 9.1.0 [MOB-2016] Fix locker image color on theme update (#601) Update release_notes.txt for 9.1.0 Updates for project Ecosia iOS Release Notes (#604) * Translate release_notes.txt in de 100% translated source file: 'release_notes.txt' on 'de'. * Translate release_notes.txt in nl 100% translated source file: 'release_notes.txt' on 'nl'. * Translate release_notes.txt in es 100% translated source file: 'release_notes.txt' on 'es'. * Translate release_notes.txt in fr 100% translated source file: 'release_notes.txt' on 'fr'. * Translate release_notes.txt in it 100% translated source file: 'release_notes.txt' on 'it'. --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Version bump to 9.1.1 (#602) [MOB-2079] Fix CI push release notes and improvement (#608) * Fix `on` execution for `upload_release_notes_to_appstore` * Make sure changes are applied to `release_notes.txt` only. [MOB-2037] Integrate Engagement Service (#605) * MOB-2037 Integrate Braze Squashed commit of the following: commit d72a712 Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Tue Dec 5 12:46:54 2023 +0100 Update SPM commit bfa6310 Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Tue Dec 5 12:43:20 2023 +0100 Implement both async methods for requesting APN consent commit 76bdd14 Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Mon Dec 4 14:39:09 2023 +0100 Update SPM commit 29d279b Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Mon Dec 4 14:36:46 2023 +0100 Add APN consent and token registration commit 5c33ef1 Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Mon Dec 4 13:16:05 2023 +0100 Add Info.plist Staging/Debug Braze references commit ee20d9a Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Mon Dec 4 13:13:09 2023 +0100 ClientEngagementService commit c26f8a9 Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Thu Nov 30 18:06:32 2023 +0100 Update SPM reference commit 2fea9dc Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Thu Nov 30 18:06:24 2023 +0100 Initialize EngagementService commit 8cb230b Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Thu Nov 30 17:04:36 2023 +0100 Temporarily point to `MOB-2034_integrate_braze` branch commit a211f9b Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Thu Nov 30 17:02:33 2023 +0100 Update `SDWebImage` to work with Braze commit 9d53f1e Author: Dario Carlomagno <dario.carlomagno@gmail.com> Date: Thu Nov 30 17:01:57 2023 +0100 Make `EngagementService` component * Update comment in `AppDelegate` for APN * Readd changes after faulty commit * Update SPM * Add `Production` CI generation [MOB-2048] Push notification card UI (#606) [MOB-2087] Update Braze Unleash Toggle (#609) * Update SPM * Update Braze Unleash Toggle [MOB-2060] Add engagement service analytics (#610) * Add analytics for APNConsent * Add `toggleName` in `EngagementServiceExperiment` to keep it angostic * Move `view` event for APN Consent from `willAppear` to `didAppear` * Remove useless value in `APNConsent.Action` * Rename `EngagementServiceExperiment` -> `APNConsentUIExperiment` * Fix indentation * Fix check on allow/deny [MOB-2090] - Register for APN every app launch if needed (#611) Update project to accommodate the APNConsent work Updates for project Ecosia iOS Search App (#612) * Translate Ecosia.strings in fr 100% translated source file: 'Ecosia.strings' on 'fr'. * Translate Ecosia.strings in es 100% translated source file: 'Ecosia.strings' on 'es'. * Translate Ecosia.strings in de 100% translated source file: 'Ecosia.strings' on 'de'. * Translate Ecosia.strings in de 100% translated source file: 'Ecosia.strings' on 'de'. * Translate Ecosia.strings in de 100% translated source file: 'Ecosia.strings' on 'de'. * Translate Ecosia.strings in it 100% translated source file: 'Ecosia.strings' on 'it'. * Translate Ecosia.strings in nl 100% translated source file: 'Ecosia.strings' on 'nl'. * Translate Ecosia.strings in nl 100% translated source file: 'Ecosia.strings' on 'nl'. * Translate Ecosia.strings in nl 100% translated source file: 'Ecosia.strings' on 'nl'. --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Update release_notes for 9.2.0 [MOB-2112] Add Debug setting for EngagementService identifier (#615) Co-authored-by: Ecosia <dariocarlomagno@Darios-Ecosias-MacBook-Pro.local> Updates for project Ecosia iOS Release Notes (#614) * Translate release_notes.txt in fr 100% translated source file: 'release_notes.txt' on 'fr'. * Translate release_notes.txt in fr 100% translated source file: 'release_notes.txt' on 'fr'. * Translate release_notes.txt in it 100% translated source file: 'release_notes.txt' on 'it'. * Translate release_notes.txt in es 100% translated source file: 'release_notes.txt' on 'es'. * Translate release_notes.txt in de 100% translated source file: 'release_notes.txt' on 'de'. * Translate release_notes.txt in nl 100% translated source file: 'release_notes.txt' on 'nl'. * Translate release_notes.txt in nl 100% translated source file: 'release_notes.txt' on 'nl'. * Translate release_notes.txt in nl 100% translated source file: 'release_notes.txt' on 'nl'. --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Add `when` flag to `deploy-release`. (#616) [MOB-2116] Add `Production.xcconfig` to Ecosia setting (#617) Co-authored-by: Ecosia <dariocarlomagno@Darios-Ecosias-MacBook-Pro.local> [MOB-2121] Braze initialization logic behind flag (#619) * Update after Unleash toggle rename * Update proj refs * Update `ClientEngagementService` init * Temporarily point `Core` SPM to feature branch * Remove useless code * Update SPM [MOB-2129] Make sure Unleash is retrieved at app start (#621) * Update FeatureManagement's configuration retrieval * Revert `EngagementService` from Feature to Experiment Bump version to 9.2.3 (#622) [MOB-2069] Fix wrong default search engine during experiment [MOB-2131] Settings opens via new FF architecture [MOB-2056] Fix Ecosia onboarding keep showing up [MOB-2055] Fix Invite Friends button crash Fix delegate for `HomepageViewControllerDelegate` [MOB-2058] Update Icon + copy + remove private badge [MOB-2058] Restore tabs functionality [MOB-2058] Add TabToolbar missing buttons to Ecosia asset [MOB-2058] Fix "Close all" responds to theme changes [MOB-2092] Update TopSites dimensions [MOB-2092] Other: Update NTP Background [MOB-2092] Fine tune topsites dimension Fix nudge bookmarks view theme Always returns 4 items in topsites list [MOB-2059] Aligned Ecosia comments on URLBarView [MOB-2054] Update cross icon on NTPToolTip [MOB-2059] Align Top Tabs theme + private button Update Suggested Sites [MOB-2059] URLBar looks like current production [MOB-2099] Fix Bookmarks, Downloads and Reading List height Apply the height alignment on iPhone only for all 3 sections [MOB-2099] Small adjustments in themeing for the top shortcuts Update SPM [MOB-2054] Update on view appear/disappear with Ecosia tasks Update code removal comment [MOB-2054] Make NTPTooltip adjust frame as expected. Also remove some useless code Add `homePanelBackground` color Align fonts in bookmarks [MOB-2096] Align History panel layout page Add `EmptyReadingListView` to better support appearance [MOB-2112] Readd `More` button in Bookmarks section [MOB-2013] Menu Action sheet looks like production (as of 9.x) [MOB-2013] Add Customize Homepage in Menu Action sheet Remove `UIColor` ref from color palette [MOB-2207] Remove sponsored sites Add Ecosia's set of Favicons correctly. Fix Top suggested sites [MOB-2202] Toast (popup) looks almost like in v104 [MOB-2202] Toast (popup) font fine tune [MOB-2202] Toast (popup) looks like v104 [MOB-2202] Toast (popup) text leading alignment improvement [MOB-2130] TableView in Settings is grouped [MOB-2130] Update navigationBar properties in settings [MOB-2130] Update Default Browser title [MOB-2130] Review Settings sections first iteration [MOB-2130] Add `settingsDelegate` in Homepage setting [MOB-2130] Fix Theme injection in NTPCustomization page [MOB-2130] Aligned Settings page sections and items Upate `var` -> `let` Remove `CircleButton` Themeable conformance Update `addNewTabButton.applyTheme` to new `applyTheme` Update toolbar search/add button Change `addNewTabButton` to configurable CircleButton + UI Fixes ToolbarButton conforms to ThemeApplicable Add missing project reference to AppSettingsTableViewController Update homepage header bottom spacing Remove redundant method callsUh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.