Skip to content

fix(rhwp-chrome): 썸네일 로딩 스피너 정리 + options CSP 호환 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
postmelee wants to merge 2 commits into from
Closed

fix(rhwp-chrome): 썸네일 로딩 스피너 정리 + options CSP 호환 #167

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9edea55
Task #86: 썸네일 로딩 완료 시 스피너 제거
postmelee Apr 16, 2026
b10267b
fix(rhwp-chrome): options 페이지 CSP 호환
postmelee Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(rhwp-chrome): options 페이지 CSP 호환 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@postmelee
postmelee and Copilot committed Apr 16, 2026
commit b10267b27254efee8687a2565053d897c0eab50b
1 change: 1 addition & 0 deletions rhwp-chrome/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ copy(resolve(__dirname, 'content-script.css'), resolve(DIST, 'content-script.css
copy(resolve(__dirname, 'dev-tools-inject.js'), resolve(DIST, 'dev-tools-inject.js'));
copy(resolve(__dirname, 'sw'), resolve(DIST, 'sw'));
copy(resolve(__dirname, 'options.html'), resolve(DIST, 'options.html'));
copy(resolve(__dirname, 'options.js'), resolve(DIST, 'options.js'));

// 아이콘
mkdirSync(resolve(DIST, 'icons'), { recursive: true });
Expand Down
37 changes: 1 addition & 36 deletions rhwp-chrome/options.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,41 +40,6 @@ <h1 id="title"></h1>
<span id="privacy"></span>
</p>

<script>
// i18n 적용
document.getElementById('title').textContent = chrome.i18n.getMessage('optionsTitle');
document.getElementById('labelAutoOpen').textContent = chrome.i18n.getMessage('optionsAutoOpen');
document.getElementById('labelShowBadges').textContent = chrome.i18n.getMessage('optionsShowBadges');
document.getElementById('labelHoverPreview').textContent = chrome.i18n.getMessage('optionsHoverPreview');
document.getElementById('saved').textContent = chrome.i18n.getMessage('optionsSaved');
document.getElementById('privacy').textContent = chrome.i18n.getMessage('optionsPrivacy');

const inputs = ['autoOpen', 'showBadges', 'hoverPreview'];

// 설정 로드
chrome.storage.sync.get(
{ autoOpen: true, showBadges: true, hoverPreview: true },
(settings) => {
for (const id of inputs) {
document.getElementById(id).checked = settings[id];
}
}
);

// 설정 저장
for (const id of inputs) {
document.getElementById(id).addEventListener('change', () => {
const settings = {};
for (const id2 of inputs) {
settings[id2] = document.getElementById(id2).checked;
}
chrome.storage.sync.set(settings, () => {
const saved = document.getElementById('saved');
saved.classList.add('show');
setTimeout(() => saved.classList.remove('show'), 1500);
});
});
}
</script>
<script src="options.js"></script>
</body>
</html>
34 changes: 34 additions & 0 deletions rhwp-chrome/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// i18n 적용
document.getElementById('title').textContent = chrome.i18n.getMessage('optionsTitle');
document.getElementById('labelAutoOpen').textContent = chrome.i18n.getMessage('optionsAutoOpen');
document.getElementById('labelShowBadges').textContent = chrome.i18n.getMessage('optionsShowBadges');
document.getElementById('labelHoverPreview').textContent = chrome.i18n.getMessage('optionsHoverPreview');
document.getElementById('saved').textContent = chrome.i18n.getMessage('optionsSaved');
document.getElementById('privacy').textContent = chrome.i18n.getMessage('optionsPrivacy');

const inputs = ['autoOpen', 'showBadges', 'hoverPreview'];

// 설정 로드
chrome.storage.sync.get(
{ autoOpen: true, showBadges: true, hoverPreview: true },
(settings) => {
for (const id of inputs) {
document.getElementById(id).checked = settings[id];
}
}
);

// 설정 저장
for (const id of inputs) {
document.getElementById(id).addEventListener('change', () => {
const settings = {};
for (const id2 of inputs) {
settings[id2] = document.getElementById(id2).checked;
}
chrome.storage.sync.set(settings, () => {
const saved = document.getElementById('saved');
saved.classList.add('show');
setTimeout(() => saved.classList.remove('show'), 1500);
});
});
}
Comment on lines +1 to +34
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options.js가 전역 스코프에서 실행되어 inputs 등이 options 페이지 전역에 노출됩니다. 이 레포의 다른 non-module 스크립트(content-script.js, dev-tools-inject.js)는 IIFE + 'use strict'로 감싸 전역 오염을 방지하고 있어 동일 패턴을 적용하는 게 안전합니다.

Suggested change
// i18n 적용
document.getElementById('title').textContent = chrome.i18n.getMessage('optionsTitle');
document.getElementById('labelAutoOpen').textContent = chrome.i18n.getMessage('optionsAutoOpen');
document.getElementById('labelShowBadges').textContent = chrome.i18n.getMessage('optionsShowBadges');
document.getElementById('labelHoverPreview').textContent = chrome.i18n.getMessage('optionsHoverPreview');
document.getElementById('saved').textContent = chrome.i18n.getMessage('optionsSaved');
document.getElementById('privacy').textContent = chrome.i18n.getMessage('optionsPrivacy');
const inputs = ['autoOpen', 'showBadges', 'hoverPreview'];
// 설정 로드
chrome.storage.sync.get(
{ autoOpen: true, showBadges: true, hoverPreview: true },
(settings) => {
for (const id of inputs) {
document.getElementById(id).checked = settings[id];
}
}
);
// 설정 저장
for (const id of inputs) {
document.getElementById(id).addEventListener('change', () => {
const settings = {};
for (const id2 of inputs) {
settings[id2] = document.getElementById(id2).checked;
}
chrome.storage.sync.set(settings, () => {
const saved = document.getElementById('saved');
saved.classList.add('show');
setTimeout(() => saved.classList.remove('show'), 1500);
});
});
}
(function () {
'use strict';
// i18n 적용
document.getElementById('title').textContent = chrome.i18n.getMessage('optionsTitle');
document.getElementById('labelAutoOpen').textContent = chrome.i18n.getMessage('optionsAutoOpen');
document.getElementById('labelShowBadges').textContent = chrome.i18n.getMessage('optionsShowBadges');
document.getElementById('labelHoverPreview').textContent = chrome.i18n.getMessage('optionsHoverPreview');
document.getElementById('saved').textContent = chrome.i18n.getMessage('optionsSaved');
document.getElementById('privacy').textContent = chrome.i18n.getMessage('optionsPrivacy');
const inputs = ['autoOpen', 'showBadges', 'hoverPreview'];
// 설정 로드
chrome.storage.sync.get(
{ autoOpen: true, showBadges: true, hoverPreview: true },
(settings) => {
for (const id of inputs) {
document.getElementById(id).checked = settings[id];
}
}
);
// 설정 저장
for (const id of inputs) {
document.getElementById(id).addEventListener('change', () => {
const settings = {};
for (const id2 of inputs) {
settings[id2] = document.getElementById(id2).checked;
}
chrome.storage.sync.set(settings, () => {
const saved = document.getElementById('saved');
saved.classList.add('show');
setTimeout(() => saved.classList.remove('show'), 1500);
});
});
}
})();

Copilot uses AI. Check for mistakes.
Loading