Skip to content

fix(rhwp-chrome): 썸네일 로딩 스피너 정리 + options CSP 호환 #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwardkim merged 5 commits into from
Apr 17, 2026
Merged

fix(rhwp-chrome): 썸네일 로딩 스피너 정리 + options CSP 호환 #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9edea55
Task #86: 썸네일 로딩 완료 시 스피너 제거
postmelee Apr 16, 2026
b10267b
fix(rhwp-chrome): options 페이지 CSP 호환
postmelee Apr 16, 2026
503967f
fix(rhwp-chrome): options.js IIFE + 'use strict' 적용
postmelee Apr 16, 2026
bb62838
Merge branch 'devel' into fix/chrome-clean-v2
postmelee Apr 16, 2026
779de81
chore(rhwp-chrome): 버전 표기 및 문서 예시 정합성 보정
postmelee Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rhwp-chrome/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ copy(resolve(__dirname, 'content-script.css'), resolve(DIST, 'content-script.css
copy(resolve(__dirname, 'dev-tools-inject.js'), resolve(DIST, 'dev-tools-inject.js'));
copy(resolve(__dirname, 'sw'), resolve(DIST, 'sw'));
copy(resolve(__dirname, 'options.html'), resolve(DIST, 'options.html'));
copy(resolve(__dirname, 'options.js'), resolve(DIST, 'options.js'));

// 아이콘
mkdirSync(resolve(DIST, 'icons'), { recursive: true });
Expand Down
5 changes: 3 additions & 2 deletions rhwp-chrome/content-script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@

// 확장 존재 알림
document.documentElement.setAttribute('data-hwp-extension', 'rhwp');
document.documentElement.setAttribute('data-hwp-extension-version', '0.1.0');
document.documentElement.setAttribute('data-hwp-extension-version', '0.1.1');
window.dispatchEvent(new CustomEvent('hwp-extension-ready', {
detail: { name: 'rhwp', version: '0.1.0', capabilities: ['preview', 'edit', 'print'] }
detail: { name: 'rhwp', version: '0.1.1', capabilities: ['preview', 'edit', 'print'] }
}));

// 개발자 도구 주입 (페이지 컨텍스트에 rhwpDev 노출)
Expand Down Expand Up @@ -67,6 +67,7 @@
img.src = new URL(dataUri).href;
img.alt = '미리보기';
img.referrerPolicy = 'no-referrer';
thumbDiv.textContent = '';
thumbDiv.className = 'rhwp-hover-thumb';
thumbDiv.appendChild(img);
}
Expand Down
4 changes: 2 additions & 2 deletions rhwp-chrome/dev-tools-inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
'use strict';
if (window.rhwpDev) return;

const VERSION = '0.1.0';
const VERSION = '0.1.1';

window.rhwpDev = {
inspect() {
Expand Down Expand Up @@ -127,7 +127,7 @@
data-hwp="true"
data-hwp-title="전입신고서"
data-hwp-pages="2"
data-hwp-thumbnail="/thumbs/preview.webp"
data-hwp-thumbnail="https://example.com/thumbs/preview.webp"
Copy link
Copy Markdown
Contributor Author

@postmelee postmelee Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rhwpDev.help() 출력 예시에서 사용자에게 보여주는 코드:
data-hwp-thumbnail="/thumbs/preview.webp" ← 상대경로

그러나 실제로 이 속성값을 표시하는 로직(content-script.js:60)은:
function isSafeImageUrl(url) {
try {
const parsed = new URL(url); // ← base 인자 없음
return parsed.protocol === 'https:' || parsed.protocol === 'http:';
} catch { return false; }
}

new URL("/thumbs/preview.webp") 는 base 없으면 TypeError를 던집니다 → catch에서 false → 썸네일 거절.

즉 사용자가 help 가이드를 그대로 따라 data-hwp-thumbnail="/thumbs/preview.webp"라고 적으면 썸네일이
표시되지 않습니다. 가이드와 실제 동작이 어긋나는 상태였습니다.

data-hwp-category="민원서식"
data-hwp-form-fields="true">전입신고서</a>

Expand Down
39 changes: 2 additions & 37 deletions rhwp-chrome/options.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,45 +36,10 @@ <h1 id="title"></h1>

<hr>
<p class="info">
rhwp v0.1.0 — MIT<br>
rhwp v<span id="version">-</span> — MIT<br>
<span id="privacy"></span>
</p>

<script>
// i18n 적용
document.getElementById('title').textContent = chrome.i18n.getMessage('optionsTitle');
document.getElementById('labelAutoOpen').textContent = chrome.i18n.getMessage('optionsAutoOpen');
document.getElementById('labelShowBadges').textContent = chrome.i18n.getMessage('optionsShowBadges');
document.getElementById('labelHoverPreview').textContent = chrome.i18n.getMessage('optionsHoverPreview');
document.getElementById('saved').textContent = chrome.i18n.getMessage('optionsSaved');
document.getElementById('privacy').textContent = chrome.i18n.getMessage('optionsPrivacy');

const inputs = ['autoOpen', 'showBadges', 'hoverPreview'];

// 설정 로드
chrome.storage.sync.get(
{ autoOpen: true, showBadges: true, hoverPreview: true },
(settings) => {
for (const id of inputs) {
document.getElementById(id).checked = settings[id];
}
}
);

// 설정 저장
for (const id of inputs) {
document.getElementById(id).addEventListener('change', () => {
const settings = {};
for (const id2 of inputs) {
settings[id2] = document.getElementById(id2).checked;
}
chrome.storage.sync.set(settings, () => {
const saved = document.getElementById('saved');
saved.classList.add('show');
setTimeout(() => saved.classList.remove('show'), 1500);
});
});
}
</script>
<script src="options.js"></script>
</body>
</html>
39 changes: 39 additions & 0 deletions rhwp-chrome/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
(function () {
'use strict';

// i18n 적용
document.getElementById('title').textContent = chrome.i18n.getMessage('optionsTitle');
document.getElementById('labelAutoOpen').textContent = chrome.i18n.getMessage('optionsAutoOpen');
document.getElementById('labelShowBadges').textContent = chrome.i18n.getMessage('optionsShowBadges');
document.getElementById('labelHoverPreview').textContent = chrome.i18n.getMessage('optionsHoverPreview');
document.getElementById('saved').textContent = chrome.i18n.getMessage('optionsSaved');
document.getElementById('privacy').textContent = chrome.i18n.getMessage('optionsPrivacy');
document.getElementById('version').textContent = chrome.runtime.getManifest().version;

const inputs = ['autoOpen', 'showBadges', 'hoverPreview'];

// 설정 로드
chrome.storage.sync.get(
{ autoOpen: true, showBadges: true, hoverPreview: true },
(settings) => {
for (const id of inputs) {
document.getElementById(id).checked = settings[id];
}
}
);

// 설정 저장
for (const id of inputs) {
document.getElementById(id).addEventListener('change', () => {
const settings = {};
for (const id2 of inputs) {
settings[id2] = document.getElementById(id2).checked;
}
chrome.storage.sync.set(settings, () => {
const saved = document.getElementById('saved');
saved.classList.add('show');
setTimeout(() => saved.classList.remove('show'), 1500);
});
});
}
})();
1 change: 0 additions & 1 deletion rhwp-chrome/sw/thumbnail-extractor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export async function extractThumbnailFromUrl(url) {
const buffer = await response.arrayBuffer();
const data = new Uint8Array(buffer);

// HWP(CFB) 또는 HWPX(ZIP) 감지
// HWP(CFB) 또는 HWPX(ZIP) 감지
const isZip = data.length >= 4 && data[0] === 0x50 && data[1] === 0x4B;
const result = isZip
Expand Down