[perf/stringify]: Use a Map for prevObjects in createNode #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeRalphson
force-pushed
the
stringify-perf
branch
from
c57b806 to
0234a6f
Compare
eemeli
approved these changes
Mar 5, 2020
Owner
|
Thank you, this is excellent! And apologies for taking so long to get to this, I was bogged down by other stuff and wanted to make sure that this would not cause any problems in browsers. But as it turns out, I'd forgotten that even IE 11 supports I'll put together a new minor release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
Array.findmethod forprevObjectsseems to be a serious bottleneck in thestringifymethod (src/schema/indexcreateNodemethod).On a 14Mb YAML file, with this change, time to run
stringifydropped from around 4 minutes to 4 seconds on my machine.I get the same test results before and after.