Skip to content

Conversation

@atian25
Copy link
Member

@atian25 atian25 commented Aug 13, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

eggjs/egg#4418
eggjs/egg#4421

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #224 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files          19       19           
  Lines        1016     1021    +5     
=======================================
+ Hits         1014     1019    +5     
  Misses          2        2           
Impacted Files Coverage Δ
lib/utils/timing.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ff868...ea69e5d. Read the comment docs.

Copy link
Member

@popomore popomore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@popomore popomore merged commit 9b371fa into master Aug 18, 2020
@popomore popomore deleted the timing branch August 18, 2020 02:40
@popomore
Copy link
Member

qingdengyue pushed a commit to qingdengyue/egg-core that referenced this pull request Dec 24, 2020
hyj1991 pushed a commit to hyj1991/egg-core that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants