Skip to content

First implementation of Data Sources #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eguiraud merged 15 commits into from
Sep 19, 2017
Merged

First implementation of Data Sources #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
72258d5
[TDF] TDataSource: number of slots is an unsigned int and not ULong64_t
dpiparo Sep 15, 2017
889466a
[TDF] Add the TTrivialDS and its unit tests
dpiparo Sep 15, 2017
9978e2b
[TDF] Make TLoopManager the entity setting the TDS number of slots
dpiparo Sep 16, 2017
a87e3b1
[TDF] Assert on multiple number of nodes setting and add unit
dpiparo Sep 16, 2017
099497a
[TDF] Spelling mistake in a variable name
dpiparo Sep 16, 2017
cf9d6bc
[TDF] Formatting
dpiparo Sep 16, 2017
36d08dd
[TDF] First working version of RootTDF and its unit tests.
dpiparo Sep 18, 2017
b7a17d4
[TDF] Refactor data sources in headers and implementation files
dpiparo Sep 18, 2017
7dfcf2a
[TDF] Specify the name of the namespace being closed
dpiparo Sep 18, 2017
bea5873
[TDF] Add all needed includes, properly choose between quotes and ang…
dpiparo Sep 18, 2017
bdd4603
[TDF] Improve DS doc and refine interface
dpiparo Sep 18, 2017
34b5856
[TDF] Default virtual ctor done the modern way
dpiparo Sep 18, 2017
a4c1364
[TDF] Free memory of POD branches, JIT SetBranchAddress calls for Cla…
dpiparo Sep 19, 2017
6d9c760
[TDF] Enclose death test between ifdef to run only for dbg builds
dpiparo Sep 19, 2017
983b726
[TDF] Simplify TLoopManager ctor
bluehood Sep 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[TDF] Assert on multiple number of nodes setting and add unit
  • Loading branch information
@dpiparo
dpiparo committed Sep 19, 2017
commit a87e3b10be0b807e682d4b21c74ff055850a6df8
4 changes: 1 addition & 3 deletions tree/treeplayer/inc/ROOT/TTrivialDS.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@ public:

void SetNSlots(unsigned int nSlots)
{
if (0U != fNSlots) {
return;
}
assert(0U == fNSlots && "Setting the number of slots even if the number of slots is different from zero.");

fNSlots = nSlots;
fCounter.resize(fNSlots);
Expand Down
10 changes: 10 additions & 0 deletions tree/treeplayer/test/dataframe/datasource_trivial.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@ TEST(TTrivialDS, ColumnReaders)
}
}

TEST(TTrivialDS, SetNSlotsTwice)
{
auto theTest = []() {
TTrivialDS tds(1);
tds.SetNSlots(1);
tds.SetNSlots(1);
};
ASSERT_DEATH(theTest(), "Setting the number of slots even if the number of slots is different from zero.");
}

TEST(TTrivialDS, FromATDF)
{
std::unique_ptr<TDataSource> tds(new TTrivialDS(32));
Expand Down