enable comment of conf titles#750
Merged
ffdfgdfg merged 1 commit intoehang-io:devfrom Apr 7, 2021
hellodword:patch-1
Merged
Conversation
|
我正想提issue呢,第一次用,把默认配置里的条目注释掉了,结果启动一直报错,最后用无配置文件方式启动才行 |
Contributor
|
这类配置,后续考虑yaml来处理更灵活 |
kirikoko1213
pushed a commit
to kirikoko1213/nps
that referenced
this pull request
Jul 26, 2022
enable comment of conf titles
axfinn
pushed a commit
to axfinn/nps
that referenced
this pull request
Jul 28, 2025
enable comment of conf titles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
简单处理一下可以更好地支持注释
否则不支持注释 title,会被匹配到 title 最后在 npc 中出错。
这只是个简单的 fix,但感觉 nps 对于 config 的解析代码这块可能需要重新考虑一下,正则太暴力了 (例如 go-ini/ini)。
很好用的工具,感谢。