Skip to content

Conversation

@trentm
Copy link
Member

@trentm trentm commented Aug 2, 2022

Change #2831 showed an example where node v16.15.0 and ealier were
insufficient for our dist build. The dist build for release is done by
CI that specifies the requisite node version, but it could be helpful
for a local dev to have a sufficient version.

.nvmrc is just advisory, so there is no expected impact.

Change #2831 showed an example where node v16.15.0 and ealier were
insufficient for our dist build. The dist build *for release* is done by
CI that specifies the requisite node version, but it could be helpful
for a local dev to have a sufficient version.

.nvmrc is just advisory, so there is no expected impact.
@trentm trentm requested a review from astorm August 2, 2022 23:34
@trentm trentm self-assigned this Aug 2, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 2, 2022
@ghost
Copy link

ghost commented Aug 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-02T23:34:44.777+0000

  • Duration: 19 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 257814
Skipped 0
Total 257814

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit 5924a16 into main Aug 3, 2022
@trentm trentm deleted the trentm/bump-nvmrc branch August 3, 2022 19:32
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Change elastic#2831 showed an example where node v16.15.0 and ealier were
insufficient for our dist build. The dist build *for release* is done by
CI that specifies the requisite node version, but it could be helpful
for a local dev to have a sufficient version.

.nvmrc is just advisory, so there is no expected impact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants