Skip to content

fix: restore ESM testing with Node.js >=v18.19.0 and v20 and v21; clarify ESM Node.js version support #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trentm merged 3 commits into from
Feb 2, 2024
Merged

fix: restore ESM testing with Node.js >=v18.19.0 and v20 and v21; clarify ESM Node.js version support #3857

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1551ce8
fix: attempt ESM testing with Node.js >=v18.19.0 and v20 and v21 again
trentm Feb 1, 2024
43a0c6c
re-enable testing with Node.js ^18.1.0 || >=20.2.0; clarify some ESM …
trentm Feb 1, 2024
bba5f42
lint:fix
trentm Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: attempt ESM testing with Node.js >=v18.19.0 and v20 and v21 again 
This is to see if [email protected] has resolved ESM instrumentation issues for
this agent.
  • Loading branch information
@trentm
trentm committed Feb 1, 2024
commit 1551ce87456d507f1308a8865a941f37a6c52ab6
3 changes: 1 addition & 2 deletions .ci/tav.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"// versions": "Skip >=18.19.0 until IITM double-import issue is resolved.",
"versions": [ "21", "20", "18.18.2", "16", "14" ],
"versions": [ "21", "20", "18", "16", "14" ],
"// modules": [
"List of instrumented modules with the minimum Node major version supported.",
"minMajorVersion for each module should be kept in sync with .tav.yml"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ jobs:
- '21.0'
- '20'
- '20.0'
- '18.18.2' # Skip >=18.19.0 until IITM double-import issue is resolved.
- '18'
- '18.0'
- '16'
- '16.0'
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ See the <<upgrade-to-v4>> guide.

*Known issue*: Using the APM agent's <<esm>> with Node v18.19.0 is currently
not supported. Earlier versions of Node.js v18 and Node.js v20 and later
*are* supported. See <https://github.com/elastic/apm-agent-nodejs/issues/3784>
*are* supported. See https://github.com/elastic/apm-agent-nodejs/issues/3784
for details.

[float]
Expand Down
5 changes: 3 additions & 2 deletions test/testconsts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ const os = require('os');
// https://github.com/nodejs/node/pull/42881
// - Current node v20 does not work with IITM
// https://github.com/DataDog/import-in-the-middle/pull/27
const NODE_VER_RANGE_IITM = '^12.20.0 || ^14.13.1 || ^16.0.0 || ^18.1.0 <20';
const NODE_VER_RANGE_IITM_GE14 = '^14.13.1 || ^16.0.0 || ^18.1.0 <20'; // NODE_VER_RANGE_IITM minus node v12
// XXX see if we are good with [email protected] now.
const NODE_VER_RANGE_IITM = '^12.20.0 || ^14.13.1 || ^16.0.0 || >=18.1.0';
const NODE_VER_RANGE_IITM_GE14 = '^14.13.1 || ^16.0.0 || >=18.1.0'; // NODE_VER_RANGE_IITM minus node v12

// This can be passed as tape test options for tests that are timing sensitive,
// to *skip* those tests on Windows CI.
Expand Down