-
Notifications
You must be signed in to change notification settings - Fork 5k
fix(x-pack/winlogbeat): run ingest pipeline tests on CI #47395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(x-pack/winlogbeat): run ingest pipeline tests on CI #47395
Conversation
At some point the CI tests for the ingest pipeline in Winlogbeat stopped being tested on CI because there was no linux host running the unit tests. The unit tests for the pipeline tests require Docker for running Elasticsearch. This adds a new Buildkite step for x-pack/winlogbeat. It fixes the tests there broken. It removes the request body from an eslegclient debug statement that was very noisy, and in some cases extremely lengthy. It removes the deprecated 'version' from the docker-compose.yaml file used to run ES. The pipelines were mostly fine because they have been copied from elastic/integrations where they are independently testing.
[git-generate] go -C ./x-pack/winlogbeat/module/security test ./... -v -update go -C ./x-pack/winlogbeat/module/sysmon test ./... -v -update go -C ./x-pack/winlogbeat/module/powershell test ./... -v -update
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
This pull request doesn't have a |
🔍 Preview links for changed docs |
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
colleenmcginnis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs change looks okay.
leehinman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One question with SidList but it isn't blocking.
| "computer_name": "WIN-BVM4LI1L1Q6.TEST.local", | ||
| "event_data": { | ||
| "SidList": [ | ||
| "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this expected in the SidList?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but the intention is for the "standard" pipeline to match what's in the Fleet integration at https://github.com/elastic/integrations/blob/80b968725f9c769f86522c69a9cdc52a30d9e231/packages/windows/data_stream/forwarded/elasticsearch/ingest_pipeline/security_standard.yml.
And currently this is how the windows.forwarded pipeline is behaving as per https://github.com/elastic/integrations/pull/15797/files#diff-a31adecc2e9c3b480a32c5672cf718fe6d4777d94c8939c1d52d16953a0c6a2aR42
However, also as identified in my integrations PR, the system.security pipeline does not have this problem. The solution will be to get Fleet's system and windows pipelines synced up by using the file reference feature and then sync beats. https://github.com/elastic/integrations/pull/15797/files#r2474625479 🤯
Reviewer note: First commit contains code changes. Second commit is the generated golden file changes.
Proposed commit message
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs