Skip to content

Refactor to use AddOtlpExporter and LoggerProviderBuilder #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevejgordon merged 6 commits into from
Nov 22, 2024
Merged

Refactor to use AddOtlpExporter and LoggerProviderBuilder #180

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52738a1
Switch to using AddOtlpExporter method
stevejgordon Nov 21, 2024
80f0d81
Fix typo in docs
stevejgordon Nov 21, 2024
527bf02
Support skipOtlp option in the autoinstrumentation plugin
stevejgordon Nov 21, 2024
6bc0064
Pin 8.x SDK until we're ready to switch to 9.x
stevejgordon Nov 21, 2024
5367798
Switch to latest Feature
stevejgordon Nov 21, 2024
802d9c2
Update global.json
stevejgordon Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support skipOtlp option in the autoinstrumentation plugin
  • Loading branch information
@stevejgordon
stevejgordon committed Nov 21, 2024
commit 527bf02aead5890e5cd9442c8092c8a8738a8264
13 changes: 9 additions & 4 deletions src/Elastic.OpenTelemetry/AutoInstrumentationPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ public class AutoInstrumentationPlugin
private readonly ILogger _logger;
private readonly EventListener _eventListener;

private readonly bool _skipOtlp;

/// <inheritdoc cref="AutoInstrumentationPlugin"/>
public AutoInstrumentationPlugin()
{
Expand All @@ -31,6 +33,11 @@ public AutoInstrumentationPlugin()

_logger = logger;
_eventListener = eventListener;

var skipOtlpString = Environment.GetEnvironmentVariable("ELASTIC_OTEL_SKIP_OTLP_EXPORTER");

if (skipOtlpString is not null && bool.TryParse(skipOtlpString, out var skipOtlp))
_skipOtlp = skipOtlp;
}

/// To access TracerProvider right after TracerProviderBuilder.Build() is executed.
Expand All @@ -45,22 +52,20 @@ public void MeterProviderInitialized(MeterProvider meterProvider)

/// To configure tracing SDK before Auto Instrumentation configured SDK
public TracerProviderBuilder BeforeConfigureTracerProvider(TracerProviderBuilder builder) =>
builder.UseElasticDefaults(_logger);

builder.UseElasticDefaults(_skipOtlp, _logger);

/// To configure tracing SDK after Auto Instrumentation configured SDK
public TracerProviderBuilder AfterConfigureTracerProvider(TracerProviderBuilder builder) =>
builder;

/// To configure metrics SDK before Auto Instrumentation configured SDK
public MeterProviderBuilder BeforeConfigureMeterProvider(MeterProviderBuilder builder) =>
builder.UseElasticDefaults(_logger);
builder.UseElasticDefaults(_skipOtlp, _logger);

/// To configure metrics SDK after Auto Instrumentation configured SDK
public MeterProviderBuilder AfterConfigureMeterProvider(MeterProviderBuilder builder) =>
builder;


/// To configure logs SDK (the method name is the same as for other logs options)
public void ConfigureLogsOptions(OpenTelemetryLoggerOptions options) =>
options.UseElasticDefaults(_logger);
Expand Down