Use native .NET 9 traces and metrics for HTTP instrumentation #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
previously approved these changes
Feb 14, 2025
Member
|
Are the e2e test failures still expected? |
Contributor
Author
For now, yes. I need to spend some time on those after decoupling the build/test of auto instrumentation. |
trentm
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On .NET 9, the BCL includes OTel-compliant instrumentation for HTTP, which is now preferred over using the contrib instrumentation. For .NET 9+ targets, we check if the contrib library is referenced, and if so, load that via reflection. Otherwise, we register the System.Net.Http source.
Closes #195