Skip to content

Refactoring bootstrap logic and enhance logging #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevejgordon merged 3 commits into from
Mar 3, 2025
Merged

Refactoring bootstrap logic and enhance logging #229

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ff783e
Refactoring bootstrap logic and enhance logging
stevejgordon Feb 28, 2025
6815f05
Skip adding service name
stevejgordon Feb 28, 2025
00f39a5
Refactor caching of components based on options
stevejgordon Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip adding service name
  • Loading branch information
@stevejgordon
stevejgordon committed Feb 28, 2025
commit 6815f053090965eefd6531d5729b2f7ca467abe8
15 changes: 0 additions & 15 deletions src/Elastic.OpenTelemetry/Extensions/ResourceBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,23 +52,8 @@ internal static ResourceBuilder WithElasticDefaults(this ResourceBuilder builder
"is guarded by a RuntimeFeature.IsDynamicCodeSupported` check and therefore this method is safe to call in AoT scenarios.")]
private static void ConfigureBuilder(ResourceBuilder builder, BuilderState builderState, IServiceCollection? services)
{
var defaultServiceName = "unknown_service";

try
{
var processName = Process.GetCurrentProcess().ProcessName;
if (!string.IsNullOrWhiteSpace(processName))
defaultServiceName = processName;
}
catch (Exception ex)
{
builderState.Components.Logger.LogError(new EventId(510, "GetCurrentProcessFailed"), ex, "An exception occurred when attempting to " +
"get determine the process name.");
}

var attributes = new Dictionary<string, object>
{
{ ResourceSemanticConventions.AttributeServiceName, defaultServiceName },
{ ResourceSemanticConventions.AttributeServiceInstanceId, ApplicationInstanceId },
{ ResourceSemanticConventions.AttributeTelemetryDistroName, "elastic" },
{ ResourceSemanticConventions.AttributeTelemetryDistroVersion, VersionHelper.InformationalVersion }
Expand Down
Loading